Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 693073002: [fsp] Polish icons in Files app. (Closed)

Created:
6 years, 1 month ago by mtomasz
Modified:
6 years, 1 month ago
Reviewers:
fukino, yawano
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[fsp] Polish icons in Files app. This patch makes the icons smaller plus fixes the mask, so they are always white (except transparent pixels) when selected. TBR=fukino@chromium.org TEST=Tested manually with 3 different icons. BUG=412602 Committed: https://crrev.com/05d0d0bf4f6f590c757d3ba4110d03dcad71c001 Cr-Commit-Position: refs/heads/master@{#302224}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M ui/file_manager/file_manager/foreground/css/file_types.css View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/directory_tree.js View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
mtomasz
@yawano: PTAL. Thanks!
6 years, 1 month ago (2014-10-31 01:39:03 UTC) #2
yawano
lgtm. Thank you!
6 years, 1 month ago (2014-10-31 02:54:50 UTC) #3
mtomasz
On 2014/10/31 02:54:50, yawano wrote: > lgtm. Thank you! Thanks!
6 years, 1 month ago (2014-10-31 03:04:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693073002/1
6 years, 1 month ago (2014-10-31 04:16:52 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 1 month ago (2014-10-31 04:16:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693073002/1
6 years, 1 month ago (2014-10-31 04:18:37 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-31 04:59:42 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 05:00:19 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/05d0d0bf4f6f590c757d3ba4110d03dcad71c001
Cr-Commit-Position: refs/heads/master@{#302224}

Powered by Google App Engine
This is Rietveld 408576698