Add Plugin.FlashUsage to histograms.xml.

Add Plugin.FlashUsage to histograms.xml.

The C++ code was added in r185124, but without the histograms.xml entry,
we cannot view the histogram.

Committed: https://crrev.com/5c9663ce3d2f5e85305ca61d2a1a4135744807ed
Cr-Commit-Position: refs/heads/master@{#302321}

[Lei Zhang, 2014-10-31 01:23:19]

thestig@chromium.org changed reviewers:
+ isherman@chromium.org, yzshen@chromium.org

[Ilya Sherman, 2014-10-31 02:13:44]

LGTM % two suggestions:

https://codereview.chromium.org/693063002/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/693063002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:44796: +  <int value="0"
label="StartedNpapiFlashAtLeastOnce">
nit: I'd format this as "Started NPAPI Flash at least once"

https://codereview.chromium.org/693063002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:44804: +  <int value="2"
label="TotalBrowserProcesses">
nit: Perhaps "Browser process launched" or "Launched browser process" or
"Started browser process" to match the other labels?

[Lei Zhang, 2014-10-31 05:41:40]

https://codereview.chromium.org/693063002/diff/1/tools/metrics/histograms/his...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/693063002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:44796: +  <int value="0"
label="StartedNpapiFlashAtLeastOnce">
On 2014/10/31 02:13:44, Ilya Sherman wrote:
> nit: I'd format this as "Started NPAPI Flash at least once"

Done.

https://codereview.chromium.org/693063002/diff/1/tools/metrics/histograms/his...
tools/metrics/histograms/histograms.xml:44804: +  <int value="2"
label="TotalBrowserProcesses">
On 2014/10/31 02:13:44, Ilya Sherman wrote:
> nit: Perhaps "Browser process launched" or "Launched browser process" or
> "Started browser process" to match the other labels?

Done.

[yzshen1, 2014-10-31 19:25:09]

LGTM

I remember that I did make corresponding changes and view this histogram before.
Weird.

IIRC, at some point this XML file is in src-internal, right? Maybe that is why.

[Lei Zhang, 2014-10-31 19:37:37]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2014-10-31 19:39:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/693063002/20001

[commit-bot: I haz the power, 2014-10-31 20:45:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-10-31 20:46:34]

Patchset 2 (id:??) landed as
https://crrev.com/5c9663ce3d2f5e85305ca61d2a1a4135744807ed
Cr-Commit-Position: refs/heads/master@{#302321}

[Ilya Sherman, 2014-10-31 22:39:49]

Ah, yes, it does look like this histogram definition was in the internal file
(which now lives in google3).  I'll go ahead and delete it, but it would be
great if someone could audit the Plugin.* histograms and hopefully move most or
all of them to the public repository.

[Lei Zhang, 2014-10-31 22:46:01]

On 2014/10/31 22:39:49, Ilya Sherman wrote:
> Ah, yes, it does look like this histogram definition was in the internal file
> (which now lives in google3).  I'll go ahead and delete it, but it would be
> great if someone could audit the Plugin.* histograms and hopefully move most
or
> all of them to the public repository.

Weird, I wanted to see the histogram but it wasn't in the list on the UMA
server.

[Ilya Sherman, 2014-10-31 22:47:00]

On 2014/10/31 22:46:01, Lei Zhang wrote:
> On 2014/10/31 22:39:49, Ilya Sherman wrote:
> > Ah, yes, it does look like this histogram definition was in the internal
file
> > (which now lives in google3).  I'll go ahead and delete it, but it would be
> > great if someone could audit the Plugin.* histograms and hopefully move most
> or
> > all of them to the public repository.
> 
> Weird, I wanted to see the histogram but it wasn't in the list on the UMA
> server.

That's because the histogram had no owner assigned to it in the internal repo.