Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Issue 693053002: Fix issue with DOM Distiller viewer when renderer goes away. (Closed)

Created:
6 years, 1 month ago by nyquist
Modified:
6 years, 1 month ago
Reviewers:
cjhopman
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix issue with DOM Distiller viewer when renderer goes away. If the user navigates away from a distilled web page or the renderer crashes while the DomDistillerViewerSource is still active, a request can still come in. However, using the render_process_id and render_frame_id to find the live renderer (RenderFrameHost) might fail. That case used to be a DCHECK, but since this happens in the wild and is reproducible, this CL removes the DCHECK and instead just bails out early if that happens, since there is no renderer to send the data to. It also fixes another place in the same method where the RenderFrameHost used to be looked up again, but now the one that has been already found is just reused. BUG=421949 Committed: https://crrev.com/375f7364c3f315c394d3b7accbd7e236b7ea7b04 Cr-Commit-Position: refs/heads/master@{#302481}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M components/dom_distiller/content/dom_distiller_viewer_source.cc View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nyquist
cjhopman: PTAL
6 years, 1 month ago (2014-10-31 21:32:58 UTC) #2
cjhopman
lgtm
6 years, 1 month ago (2014-10-31 21:45:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693053002/1
6 years, 1 month ago (2014-11-03 20:38:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-03 21:22:38 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-03 21:23:35 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/375f7364c3f315c394d3b7accbd7e236b7ea7b04
Cr-Commit-Position: refs/heads/master@{#302481}

Powered by Google App Engine
This is Rietveld 408576698