Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 692993005: [ServiceWorkerCache] Reland backend state CL (Closed)

Created:
6 years, 1 month ago by jkarlin
Modified:
6 years, 1 month ago
Reviewers:
michaeln, falken, michaeln1
CC:
chromium-reviews, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@close_async
Project:
chromium
Visibility:
Public.

Description

[ServiceWorkerCache] Reland backend state CL Reland of: https://codereview.chromium.org/701403002/ Reverted here: https://codereview.chromium.org/709003003/ InitDone() made an illegal state transition from BACKEND_CLOSED to BACKEND_OPEN. I removed that transition, which means that pending operations will exit early instead of complete, so I updated the test expectations. I also added some new testing framework to be able to delay not only cache backend creation but backend functions themselves, so far only OpenEntry. This is used to recreate the dcheck crash discovered by the layout tests in https://crbug.com/431163 I don't intend to commit until after branch cut as this CL is mostly code cleanup and new tests. BUG=430884 Committed: https://crrev.com/6d719ce3c33f68f79a80a034363c7749e9fed756 Cr-Commit-Position: refs/heads/master@{#303648}

Patch Set 1 : Reverted CL #

Patch Set 2 : Close now cancels pending operations that require the backend #

Patch Set 3 : Nits #

Patch Set 4 : Rebase #

Patch Set 5 : Nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -74 lines) Patch
M content/browser/service_worker/service_worker_cache.h View 1 4 chunks +15 lines, -5 lines 0 comments Download
M content/browser/service_worker/service_worker_cache.cc View 1 12 chunks +66 lines, -44 lines 0 comments Download
M content/browser/service_worker/service_worker_cache_unittest.cc View 1 2 3 4 8 chunks +142 lines, -25 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
jkarlin
michaeln@chromium.org: Please review changes in all falken@chromium.org: Please review changes in all Thanks!
6 years, 1 month ago (2014-11-07 19:42:47 UTC) #4
michaeln1
lgtm
6 years, 1 month ago (2014-11-08 00:10:49 UTC) #6
michaeln
and not surprisingly lgtm 2
6 years, 1 month ago (2014-11-08 00:12:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692993005/120001
6 years, 1 month ago (2014-11-10 19:17:52 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692993005/120001
6 years, 1 month ago (2014-11-11 14:52:32 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:120001)
6 years, 1 month ago (2014-11-11 14:53:20 UTC) #14
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 14:54:00 UTC) #15
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/6d719ce3c33f68f79a80a034363c7749e9fed756
Cr-Commit-Position: refs/heads/master@{#303648}

Powered by Google App Engine
This is Rietveld 408576698