Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Unified Diff: Source/core/html/HTMLAllCollection.idl

Issue 692993003: Named getter of HTMLAllCollection etc should be nullable (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@union-nullable
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/html/HTMLAllCollection.idl
diff --git a/Source/core/html/HTMLAllCollection.idl b/Source/core/html/HTMLAllCollection.idl
index d56b8b6dbf560bd7fab369a2cfa1052ea5f9a1ee..d8664f691cdb421b8d42a1d1409149ddc5561b59 100644
--- a/Source/core/html/HTMLAllCollection.idl
+++ b/Source/core/html/HTMLAllCollection.idl
@@ -34,6 +34,6 @@
readonly attribute unsigned long length;
[ImplementedAs=item] getter Element (unsigned long index);
[Custom] Element item([Default=Undefined] optional unsigned long index);
- // FIXME: This should return an (HTMLCollection or Element) union.
- [ImplementedAs=namedGetter] getter (NodeList or Element) namedItem(DOMString name);
+ // FIXME: This should return an (HTMLCollection or Element)? union.
+ [ImplementedAs=namedGetter] getter (NodeList or Element)? namedItem(DOMString name);
};
« no previous file with comments | « LayoutTests/fast/dom/idl-union-type-unittest-expected.txt ('k') | Source/core/html/HTMLFormControlsCollection.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698