Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 692983003: Disable notification views when clearing all notifications (Closed)

Created:
6 years, 1 month ago by mohsen
Modified:
6 years, 1 month ago
Reviewers:
stevenjb
CC:
chromium-reviews, peter+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable notification views when clearing all notifications In message center bubble, when "Clear All" animation is in progress, different views are disabled to prevent interaction with them. However, NotificationView's are not disabled which can lead to one of them getting focused. They should get disabled, too. BUG=428710 Committed: https://crrev.com/e38e7b4b295e521e6bdbbacf50ab07fdea842d25 Cr-Commit-Position: refs/heads/master@{#303288}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M ui/message_center/views/message_center_view.cc View 3 chunks +12 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mohsen
Can you please take a look...
6 years, 1 month ago (2014-11-07 17:05:24 UTC) #2
miket_OOO
On 2014/11/07 17:05:24, mohsen wrote: > Can you please take a look... No, I'm not ...
6 years, 1 month ago (2014-11-07 17:27:01 UTC) #4
stevenjb
lgtm
6 years, 1 month ago (2014-11-07 17:55:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692983003/1
6 years, 1 month ago (2014-11-07 19:47:43 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-07 20:36:48 UTC) #8
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 20:37:24 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e38e7b4b295e521e6bdbbacf50ab07fdea842d25
Cr-Commit-Position: refs/heads/master@{#303288}

Powered by Google App Engine
This is Rietveld 408576698