Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Side by Side Diff: content/renderer/render_frame_proxy.cc

Issue 692973005: Pass origin information for remote frame creation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add EXPECT_TRUE to NavigateToURL in new tests; nits Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_frame_proxy.h" 5 #include "content/renderer/render_frame_proxy.h"
6 6
7 #include <map> 7 #include <map>
8 8
9 #include "base/lazy_instance.h" 9 #include "base/lazy_instance.h"
10 #include "content/child/webmessageportchannel_impl.h" 10 #include "content/child/webmessageportchannel_impl.h"
11 #include "content/common/frame_messages.h" 11 #include "content/common/frame_messages.h"
12 #include "content/common/frame_replication_state.h"
12 #include "content/common/swapped_out_messages.h" 13 #include "content/common/swapped_out_messages.h"
13 #include "content/common/view_messages.h" 14 #include "content/common/view_messages.h"
14 #include "content/renderer/child_frame_compositing_helper.h" 15 #include "content/renderer/child_frame_compositing_helper.h"
15 #include "content/renderer/render_frame_impl.h" 16 #include "content/renderer/render_frame_impl.h"
16 #include "content/renderer/render_thread_impl.h" 17 #include "content/renderer/render_thread_impl.h"
17 #include "content/renderer/render_view_impl.h" 18 #include "content/renderer/render_view_impl.h"
19
Charlie Reis 2014/11/20 17:20:28 nit: No blank line here. (Might as well remove th
alexmos 2014/11/20 21:09:10 Done.
20 #include "third_party/WebKit/public/platform/WebString.h"
18 #include "third_party/WebKit/public/web/WebLocalFrame.h" 21 #include "third_party/WebKit/public/web/WebLocalFrame.h"
19 #include "third_party/WebKit/public/web/WebUserGestureIndicator.h" 22 #include "third_party/WebKit/public/web/WebUserGestureIndicator.h"
20 #include "third_party/WebKit/public/web/WebView.h" 23 #include "third_party/WebKit/public/web/WebView.h"
21 24
22 namespace content { 25 namespace content {
23 26
24 namespace { 27 namespace {
25 28
26 // Facilitates lookup of RenderFrameProxy by routing_id. 29 // Facilitates lookup of RenderFrameProxy by routing_id.
27 typedef std::map<int, RenderFrameProxy*> RoutingIDProxyMap; 30 typedef std::map<int, RenderFrameProxy*> RoutingIDProxyMap;
(...skipping 19 matching lines...) Expand all
47 // always come from WebRemoteFrame::create and a call to WebFrame::swap must 50 // always come from WebRemoteFrame::create and a call to WebFrame::swap must
48 // follow later. 51 // follow later.
49 blink::WebRemoteFrame* web_frame = blink::WebRemoteFrame::create(proxy.get()); 52 blink::WebRemoteFrame* web_frame = blink::WebRemoteFrame::create(proxy.get());
50 proxy->Init(web_frame, frame_to_replace->render_view()); 53 proxy->Init(web_frame, frame_to_replace->render_view());
51 return proxy.release(); 54 return proxy.release();
52 } 55 }
53 56
54 RenderFrameProxy* RenderFrameProxy::CreateFrameProxy( 57 RenderFrameProxy* RenderFrameProxy::CreateFrameProxy(
55 int routing_id, 58 int routing_id,
56 int parent_routing_id, 59 int parent_routing_id,
57 int render_view_routing_id) { 60 int render_view_routing_id,
61 const FrameReplicationState& replicated_state) {
58 scoped_ptr<RenderFrameProxy> proxy( 62 scoped_ptr<RenderFrameProxy> proxy(
59 new RenderFrameProxy(routing_id, MSG_ROUTING_NONE)); 63 new RenderFrameProxy(routing_id, MSG_ROUTING_NONE));
60 RenderViewImpl* render_view = NULL; 64 RenderViewImpl* render_view = NULL;
61 blink::WebRemoteFrame* web_frame = NULL; 65 blink::WebRemoteFrame* web_frame = NULL;
62 if (parent_routing_id == MSG_ROUTING_NONE) { 66 if (parent_routing_id == MSG_ROUTING_NONE) {
63 // Create a top level frame. 67 // Create a top level frame.
64 render_view = RenderViewImpl::FromRoutingID(render_view_routing_id); 68 render_view = RenderViewImpl::FromRoutingID(render_view_routing_id);
65 web_frame = blink::WebRemoteFrame::create(proxy.get()); 69 web_frame = blink::WebRemoteFrame::create(proxy.get());
66 render_view->webview()->setMainFrame(web_frame); 70 render_view->webview()->setMainFrame(web_frame);
67 } else { 71 } else {
68 // Create a frame under an existing parent. The parent is always expected 72 // Create a frame under an existing parent. The parent is always expected
69 // to be a RenderFrameProxy, because navigations initiated by local frames 73 // to be a RenderFrameProxy, because navigations initiated by local frames
70 // should not wind up here. 74 // should not wind up here.
71 RenderFrameProxy* parent = 75 RenderFrameProxy* parent =
72 RenderFrameProxy::FromRoutingID(parent_routing_id); 76 RenderFrameProxy::FromRoutingID(parent_routing_id);
73 web_frame = parent->web_frame()->createRemoteChild("", proxy.get()); 77 web_frame = parent->web_frame()->createRemoteChild("", proxy.get());
74 render_view = parent->render_view(); 78 render_view = parent->render_view();
75 } 79 }
76 80
77 proxy->Init(web_frame, render_view); 81 proxy->Init(web_frame, render_view);
78 82
83 // Initialize proxy's WebRemoteFrame with the security origin and other
84 // replicated information.
85 proxy->SetReplicatedState(replicated_state);
86
79 return proxy.release(); 87 return proxy.release();
80 } 88 }
81 89
82 // static 90 // static
83 RenderFrameProxy* RenderFrameProxy::FromRoutingID(int32 routing_id) { 91 RenderFrameProxy* RenderFrameProxy::FromRoutingID(int32 routing_id) {
84 RoutingIDProxyMap* proxies = g_routing_id_proxy_map.Pointer(); 92 RoutingIDProxyMap* proxies = g_routing_id_proxy_map.Pointer();
85 RoutingIDProxyMap::iterator it = proxies->find(routing_id); 93 RoutingIDProxyMap::iterator it = proxies->find(routing_id);
86 return it == proxies->end() ? NULL : it->second; 94 return it == proxies->end() ? NULL : it->second;
87 } 95 }
88 96
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
134 std::pair<FrameMap::iterator, bool> result = 142 std::pair<FrameMap::iterator, bool> result =
135 g_frame_map.Get().insert(std::make_pair(web_frame_, this)); 143 g_frame_map.Get().insert(std::make_pair(web_frame_, this));
136 CHECK(result.second) << "Inserted a duplicate item."; 144 CHECK(result.second) << "Inserted a duplicate item.";
137 } 145 }
138 146
139 void RenderFrameProxy::DidCommitCompositorFrame() { 147 void RenderFrameProxy::DidCommitCompositorFrame() {
140 if (compositing_helper_.get()) 148 if (compositing_helper_.get())
141 compositing_helper_->DidCommitCompositorFrame(); 149 compositing_helper_->DidCommitCompositorFrame();
142 } 150 }
143 151
152 void RenderFrameProxy::SetReplicatedState(const FrameReplicationState& state) {
153 DCHECK(web_frame_);
154 web_frame_->setReplicatedOrigin(blink::WebSecurityOrigin::createFromString(
155 blink::WebString::fromUTF8(state.origin.string())));
156 }
157
144 bool RenderFrameProxy::OnMessageReceived(const IPC::Message& msg) { 158 bool RenderFrameProxy::OnMessageReceived(const IPC::Message& msg) {
145 bool handled = true; 159 bool handled = true;
146 IPC_BEGIN_MESSAGE_MAP(RenderFrameProxy, msg) 160 IPC_BEGIN_MESSAGE_MAP(RenderFrameProxy, msg)
147 IPC_MESSAGE_HANDLER(FrameMsg_DeleteProxy, OnDeleteProxy) 161 IPC_MESSAGE_HANDLER(FrameMsg_DeleteProxy, OnDeleteProxy)
148 IPC_MESSAGE_HANDLER(FrameMsg_ChildFrameProcessGone, OnChildFrameProcessGone) 162 IPC_MESSAGE_HANDLER(FrameMsg_ChildFrameProcessGone, OnChildFrameProcessGone)
149 IPC_MESSAGE_HANDLER_GENERIC(FrameMsg_CompositorFrameSwapped, 163 IPC_MESSAGE_HANDLER_GENERIC(FrameMsg_CompositorFrameSwapped,
150 OnCompositorFrameSwapped(msg)) 164 OnCompositorFrameSwapped(msg))
151 IPC_MESSAGE_HANDLER(FrameMsg_DisownOpener, OnDisownOpener) 165 IPC_MESSAGE_HANDLER(FrameMsg_DisownOpener, OnDisownOpener)
152 IPC_MESSAGE_UNHANDLED(handled = false) 166 IPC_MESSAGE_UNHANDLED(handled = false)
153 IPC_END_MESSAGE_MAP() 167 IPC_END_MESSAGE_MAP()
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
291 blink::WebUserGestureIndicator::isProcessingUserGesture(); 305 blink::WebUserGestureIndicator::isProcessingUserGesture();
292 blink::WebUserGestureIndicator::consumeUserGesture(); 306 blink::WebUserGestureIndicator::consumeUserGesture();
293 Send(new FrameHostMsg_OpenURL(routing_id_, params)); 307 Send(new FrameHostMsg_OpenURL(routing_id_, params));
294 } 308 }
295 309
296 void RenderFrameProxy::forwardInputEvent(const blink::WebInputEvent* event) { 310 void RenderFrameProxy::forwardInputEvent(const blink::WebInputEvent* event) {
297 Send(new FrameHostMsg_ForwardInputEvent(routing_id_, event)); 311 Send(new FrameHostMsg_ForwardInputEvent(routing_id_, event));
298 } 312 }
299 313
300 } // namespace 314 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698