Pass origin information for remote frame creation.

content/renderer/render_frame_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_frame_impl.h"
 
 #include <map>
 #include <string>
 
 #include "base/auto_reset.h"
@@ skipping 16 matching lines @@
 #include "content/child/service_worker/service_worker_network_provider.h"
 #include "content/child/service_worker/service_worker_provider_context.h"
 #include "content/child/service_worker/web_service_worker_provider_impl.h"
 #include "content/child/web_url_loader_impl.h"
 #include "content/child/web_url_request_util.h"
 #include "content/child/webmessageportchannel_impl.h"
 #include "content/child/websocket_bridge.h"
 #include "content/child/weburlresponse_extradata_impl.h"
 #include "content/common/clipboard_messages.h"
 #include "content/common/frame_messages.h"
+#include "content/common/frame_replication_state.h"
 #include "content/common/input_messages.h"
 #include "content/common/service_worker/service_worker_types.h"
 #include "content/common/swapped_out_messages.h"
 #include "content/common/view_messages.h"
 #include "content/public/common/bindings_policy.h"
 #include "content/public/common/content_constants.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/common/context_menu_params.h"
 #include "content/public/common/page_state.h"
 #include "content/public/common/resource_response.h"
@@ skipping 502 matching lines @@
   return NULL;
 }
 
 // static
 void RenderFrameImpl::InstallCreateHook(
     RenderFrameImpl* (*create_render_frame_impl)(RenderViewImpl*, int32)) {
   CHECK(!g_create_render_frame_impl);
   g_create_render_frame_impl = create_render_frame_impl;
 }
 
+
+// static
+void RenderFrameImpl::SetReplicatedState(blink::WebRemoteFrame* frame,

[Charlie Reis, 2014/11/19 00:46:18]

On second thought, maybe this belongs as a non-static method on
RenderFrameProxy, since it operates on the proxy's WebRemoteFrame?  It's easy to
call that from both RenderFrameImpl::OnSwapOut and RenderViewImpl::Initialize,
since we have the proxy object in both places.

Sorry to make you move it.

[alexmos, 2014/11/19 02:49:27]

Done - indeed, that seems much better and the code is cleaner.

+                                         const FrameReplicationState& state) {
+  CHECK(frame);

[Charlie Reis, 2014/11/19 00:46:18]

DCHECK is fine here.  It clarifies the intent, and we'll crash either way in
release builds.

[alexmos, 2014/11/19 02:49:27]

Done.

+  frame->setReplicatedOrigin(blink::WebSecurityOrigin::createFromString(
+      blink::WebString::fromUTF8(state.origin.string())));
+}
+
 // RenderFrameImpl ----------------------------------------------------------
 RenderFrameImpl::RenderFrameImpl(RenderViewImpl* render_view, int routing_id)
     : frame_(NULL),
       render_view_(render_view->AsWeakPtr()),
       routing_id_(routing_id),
       is_swapped_out_(false),
       render_frame_proxy_(NULL),
       is_detaching_(false),
       proxy_routing_id_(MSG_ROUTING_NONE),
 #if defined(ENABLE_PLUGINS)
@@ skipping 530 matching lines @@
   CHECK(!frame_->parent());
 
   base::TimeTicks before_unload_start_time = base::TimeTicks::Now();
   bool proceed = frame_->dispatchBeforeUnloadEvent();
   base::TimeTicks before_unload_end_time = base::TimeTicks::Now();
   Send(new FrameHostMsg_BeforeUnload_ACK(routing_id_, proceed,
                                          before_unload_start_time,
                                          before_unload_end_time));
 }
 
-void RenderFrameImpl::OnSwapOut(int proxy_routing_id) {
+void RenderFrameImpl::OnSwapOut(
+    int proxy_routing_id,
+    const FrameReplicationState& remote_frame_state) {
   TRACE_EVENT1("navigation", "RenderFrameImpl::OnSwapOut", "id", routing_id_);
   RenderFrameProxy* proxy = NULL;
   bool is_site_per_process =
       CommandLine::ForCurrentProcess()->HasSwitch(switches::kSitePerProcess);
   bool is_main_frame = !frame_->parent();
 
   // Only run unload if we're not swapped out yet, but send the ack either way.
   if (!is_swapped_out_ || !render_view_->is_swapped_out_) {
     // Swap this RenderFrame out so the frame can navigate to a page rendered by
     // a different process.  This involves running the unload handler and
@@ skipping 65 matching lines @@
       frame_->swap(proxy->web_frame());
       if (is_site_per_process) {
         // TODO(nasko): delete the frame here, since we've replaced it with a
         // proxy.
       }
     } else {
       set_render_frame_proxy(proxy);
     }
   }
 
+  // In --site-per-process, initialize the WebRemoteFrame with the replication
+  // state passed by the process that is now rendering the frame.
+  // TODO(alexmos): We cannot yet do this for swapped-out main frames, because
+  // in that case we leave the LocalFrame as the main frame visible to Blink
+  // and don't call swap() above. Because swap() is what creates a RemoteFrame
+  // in proxy->web_frame(), the RemoteFrame will not exist for main frames.
+  // When we do an unconditional swap for all frames, we can remove
+  // !is_main_frame below.
+  if (is_site_per_process && proxy && !is_main_frame) {
+    RenderFrameImpl::SetReplicatedState(proxy->web_frame(),
+                                        remote_frame_state);
+  }
+
   // Safe to exit if no one else is using the process.
   if (is_main_frame)
     render_view_->WasSwappedOut();
 }
 
 void RenderFrameImpl::OnContextMenuClosed(
     const CustomContextMenuContext& custom_context) {
   if (custom_context.request_id) {
     // External request, should be in our map.
     ContextMenuClient* client =
@@ skipping 2246 matching lines @@
   WebURLResponseExtraDataImpl* extra_data = GetExtraDataFromResponse(response);
   if (extra_data)
     params.was_fetched_via_proxy = extra_data->was_fetched_via_proxy();
   params.was_within_same_page = navigation_state->was_within_same_page();
   params.security_info = response.securityInfo();
 
   // Set the URL to be displayed in the browser UI to the user.
   params.url = GetLoadingUrl();
   DCHECK(!is_swapped_out_ || params.url == GURL(kSwappedOutURL));
 
+  // Set the origin of the frame.  This will be replicated to corresponding

[Charlie Reis, 2014/11/19 00:46:18]

nit: to the corresponding

[alexmos, 2014/11/19 02:49:27]

Done.

+  // RenderFrameProxies in other processes.
+  if (!is_swapped_out_) {
+      params.origin = url::Origin(

[Charlie Reis, 2014/11/19 00:46:18]

nit: 2 space indent

[alexmos, 2014/11/19 02:49:27]

Done.

+          frame->document().securityOrigin().toString().utf8());

[Charlie Reis, 2014/11/19 00:46:18]

Just checking: is toString().utf8() the right way to convert a SecurityOrigin to
a url::Origin?  (I don't see an immediate issue with it.)

[alexmos, 2014/11/19 02:49:27]

I based this off of how WebSerializedOrigin is initialized from a
SecurityOrigin, and how it exposes a url::Origin:
https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

I considered converting securityOrigin() to a WebSerializedOrigin first and
getting url::Origin off of that, but WebSerializedOrigin currently doesn't have
a constructor that takes in a WebSecurityOrigin outside of Blink, and also it
has no way to deserialize into a WebSecurityOrigin later (and adding a function
for the latter could lead to improper usage since we know deserialization
currently loses information for things like document.domain).  I also saw
origin.toString().utf8() getting used in a few other places to convert
WebSecurityOrigins to strings (e.g., RenderFrameImpl::didRunInsecureContent), so
went with this approach for now.

[Charlie Reis, 2014/11/19 19:31:46]

Acknowledged.

+  }
+
   if (frame->document().baseURL() != params.url)
     params.base_url = frame->document().baseURL();
 
   GetRedirectChain(ds, &params.redirects);
   params.should_update_history = !ds->hasUnreachableURL() &&
       !response.isMultipartPayload() && (response.httpStatusCode() != 404);
 
   params.searchable_form_url = internal_data->searchable_form_url();
   params.searchable_form_encoding = internal_data->searchable_form_encoding();
 
@@ skipping 727 matching lines @@
 
 #if defined(ENABLE_BROWSER_CDMS)
 RendererCdmManager* RenderFrameImpl::GetCdmManager() {
   if (!cdm_manager_)
     cdm_manager_ = new RendererCdmManager(this);
   return cdm_manager_;
 }
 #endif  // defined(ENABLE_BROWSER_CDMS)
 
 }  // namespace content