Pass origin information for remote frame creation.

content/browser/frame_host/frame_tree_node.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/frame_tree_node.h"
 
 #include <queue>
 
 #include "base/command_line.h"
 #include "base/stl_util.h"
@@ skipping 78 matching lines @@
   // The RenderFrame no longer exists and will need to be created again.
   current_frame_host()->set_render_frame_created(false);
 
   // The children may not have been cleared if a cross-process navigation
   // commits before the old process cleans everything up.  Make sure the child
   // nodes get deleted before swapping to a new process.
   ScopedVector<FrameTreeNode> old_children = children_.Pass();
   old_children.clear();  // May notify observers.
 }
 
+void FrameTreeNode::SetOriginFromURL(const GURL& url) {

[Charlie Reis, 2014/11/13 18:00:57]

This is more SetReplicationState, right?

+  // This mimicks blink::SecurityOrigin::create for detecting schemes that
+  // should result in unique origins.
+  // TODO(alexmos): blink::SecurityOrigin::create does other things that we may
+  // want to do here eventually (e.g., handling innerURLs for blob: and
+  // filesystem:).
+  if (!url.is_valid() ||
+      url.SchemeIs(url::kAboutScheme) ||

[dcheng, 2014/11/12 22:16:43]

Hm... this doesn't seem quite correct. about:blank inherits its parent's
security context, right?

[alexmos, 2014/11/18 18:25:32]

This and the other more complex cases are now fixed by letting Blink initialize
the origin and then passing it in serialized form in DidCommitProvisionalLoad. 
This function is no longer needed - yay.

+      url.SchemeIs(url::kDataScheme) ||
+      url.SchemeIs(url::kJavaScriptScheme)) {
+    replication_state_.is_unique_origin = true;
+    replication_state_.origin = url::Origin();

[Charlie Reis, 2014/11/13 18:00:57]

Hmm, I'm wondering if there's a better place for this code to live, since it's a
little odd to have delicate origin logic in FrameTreeNode.  That can be part of
the discussion about which class to use for the origin.

[alexmos, 2014/11/18 18:25:32]

See my answer for Daniel's question above.

+    return;
+  }
+  DCHECK(url.GetOrigin().is_valid());
+  replication_state_.origin = url::Origin(url.GetOrigin().spec());
+  replication_state_.is_unique_origin = false;
+}
+
 }  // namespace content