Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 692953002: Add support for clang to the android build scripts (Closed)

Created:
6 years, 1 month ago by djsollen
Modified:
6 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add support for clang to the android build scripts Committed: https://skia.googlesource.com/skia/+/0130c30d0ac71a26683cca39b43405fd66df3ddf

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -8 lines) Patch
M platform_tools/android/bin/android_setup.sh View 1 chunk +2 lines, -0 lines 0 comments Download
M platform_tools/android/bin/utils/setup_toolchain.sh View 4 chunks +25 lines, -8 lines 2 comments Download

Messages

Total messages: 8 (3 generated)
djsollen
6 years, 1 month ago (2014-10-30 19:12:14 UTC) #2
tomhudson
lgtm https://codereview.chromium.org/692953002/diff/1/platform_tools/android/bin/utils/setup_toolchain.sh File platform_tools/android/bin/utils/setup_toolchain.sh (right): https://codereview.chromium.org/692953002/diff/1/platform_tools/android/bin/utils/setup_toolchain.sh#newcode98 platform_tools/android/bin/utils/setup_toolchain.sh:98: # temporarily disable ccache as it is generating ...
6 years, 1 month ago (2014-10-30 19:17:32 UTC) #4
djsollen
https://codereview.chromium.org/692953002/diff/1/platform_tools/android/bin/utils/setup_toolchain.sh File platform_tools/android/bin/utils/setup_toolchain.sh (right): https://codereview.chromium.org/692953002/diff/1/platform_tools/android/bin/utils/setup_toolchain.sh#newcode98 platform_tools/android/bin/utils/setup_toolchain.sh:98: # temporarily disable ccache as it is generating errors ...
6 years, 1 month ago (2014-10-30 19:21:22 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692953002/1
6 years, 1 month ago (2014-10-31 11:44:00 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 14:01:04 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 0130c30d0ac71a26683cca39b43405fd66df3ddf

Powered by Google App Engine
This is Rietveld 408576698