Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 692933002: [Android] Add JavaBridgeBasicsTest#testReplaceJavascriptInterface (Closed)

Created:
6 years, 1 month ago by mnaganov (inactive)
Modified:
6 years, 1 month ago
Reviewers:
benm (inactive)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Android] Add JavaBridgeBasicsTest#testReplaceJavascriptInterface Add a test that replaces previously injected object with a new one under the same name. BUG=b/17973356 Committed: https://crrev.com/afd4d54f2f4c20c47b2c3fc9fe51ea4d3761153f Cr-Commit-Position: refs/heads/master@{#302262}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -22 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeBasicsTest.java View 8 chunks +44 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mnaganov (inactive)
I verified with log statements that this use case indeed causes |name| argument passed to ...
6 years, 1 month ago (2014-10-30 17:16:28 UTC) #2
benm (inactive)
lgtm
6 years, 1 month ago (2014-10-31 13:43:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692933002/1
6 years, 1 month ago (2014-10-31 13:48:36 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-31 14:29:57 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 14:30:38 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/afd4d54f2f4c20c47b2c3fc9fe51ea4d3761153f
Cr-Commit-Position: refs/heads/master@{#302262}

Powered by Google App Engine
This is Rietveld 408576698