Issue 69293015: Add a gin/public directory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 69293015: Add a gin/public directory (Closed)

Created:
7 years, 1 month ago by jochen (gone - plz use gerrit)

Modified:
7 years, 1 month ago

Reviewers:
abarth-chromium

CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add a gin/public directory When we start using gin from other projects but mojo, we want to be extra careful what we include. Therefore, we introduce a public/ directories with headers that are ok to be included from gin-embedders. As a start, we move wrapper_info.h into public/. BUG=317398 R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236114

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -36 lines)			Patch
M	gin/gin.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gin/modules/console.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gin/modules/module_registry.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gin/per_context_data.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	gin/per_isolate_data.h	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	gin/public/wrapper_info.h	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	gin/test/gtest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
D	gin/wrapper_info.h	View	1 chunk	+0 lines, -25 lines	0 comments	Download
M	gin/wrapper_info.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	mojo/public/bindings/js/core.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

LGTM We'll probably want to add a README file to the public directory at some ...

7 years, 1 month ago (2013-11-19 19:43:06 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/69293015/1

7 years, 1 month ago (2013-11-19 20:18:02 UTC) #3

Message was sent while issue was closed.

Change committed as 236114

Expand Messages | Collapse Messages