Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 69293010: MIPS: After r17654 unused EmitMathFloor breaks the build. (Closed)

Created:
7 years, 1 month ago by kilvadyb
Modified:
7 years, 1 month ago
CC:
v8-dev
Base URL:
ssh://192.168.4.100/data/kilvadyb/v8m-rb-sim@gbl
Visibility:
Public.

Description

MIPS: Fix build after r17654. FullCodeGenerator::EmitMathFloor(CallRuntime* expr) function is not used anywhere and breaks the build. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M src/mips/full-codegen-mips.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kilvadyb
7 years, 1 month ago (2013-11-12 19:10:50 UTC) #1
Paul Lind
lgtm
7 years, 1 month ago (2013-11-12 19:39:22 UTC) #2
Paul Lind
Committed as r17674.
7 years, 1 month ago (2013-11-12 19:41:35 UTC) #3
Yang
7 years, 1 month ago (2013-11-12 22:23:51 UTC) #4
Message was sent while issue was closed.
On 2013/11/12 19:41:35, Paul Lind wrote:
> Committed as r17674.

Sorry about that. I forgot to remove it after I put it there temporarily.

Powered by Google App Engine
This is Rietveld 408576698