Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Unified Diff: components/autofill/core/browser/autofill_external_delegate_unittest.cc

Issue 69293007: Abstracted AutofillMsg_SetNodeText IPC out of core autofill code. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comment. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_external_delegate_unittest.cc
diff --git a/components/autofill/core/browser/autofill_external_delegate_unittest.cc b/components/autofill/core/browser/autofill_external_delegate_unittest.cc
index 2f6f9554950afe48f8407a7a6f0e1bbd713e55f3..134915e049ccd75c2274cc46a31c8e6f57ebcf8b 100644
--- a/components/autofill/core/browser/autofill_external_delegate_unittest.cc
+++ b/components/autofill/core/browser/autofill_external_delegate_unittest.cc
@@ -46,6 +46,7 @@ class MockAutofillDriver : public TestAutofillDriver {
void(const base::string16&));
MOCK_METHOD0(RendererShouldClearFilledForm, void());
MOCK_METHOD0(RendererShouldClearPreviewedForm, void());
+ MOCK_METHOD1(RendererShouldSetNodeText, void(const base::string16&));
private:
DISALLOW_COPY_AND_ASSIGN(MockAutofillDriver);
@@ -439,11 +440,11 @@ TEST_F(AutofillExternalDelegateUnitTest, ExternalDelegatePasswordSuggestions) {
// that the user accepted the data list suggestion.
TEST_F(AutofillExternalDelegateUnitTest, ExternalDelegateAcceptSuggestion) {
EXPECT_CALL(manager_delegate_, HideAutofillPopup());
- base::string16 dummyString(ASCIIToUTF16("baz qux"));
+ base::string16 dummy_string(ASCIIToUTF16("baz qux"));
EXPECT_CALL(*autofill_driver_,
- RendererShouldAcceptDataListSuggestion(dummyString));
+ RendererShouldAcceptDataListSuggestion(dummy_string));
external_delegate_->DidAcceptSuggestion(
- dummyString,
+ dummy_string,
WebAutofillClient::MenuItemIDDataListEntry);
}
@@ -484,4 +485,14 @@ TEST_F(AutofillExternalDelegateUnitTest, ExternalDelegateHideWarning) {
autofill_ids);
}
+TEST_F(AutofillExternalDelegateUnitTest, ExternalDelegateSetNodeText) {
+ EXPECT_CALL(manager_delegate_, HideAutofillPopup());
+ base::string16 dummy_string(ASCIIToUTF16("baz foo"));
+ EXPECT_CALL(*autofill_driver_,
+ RendererShouldSetNodeText(dummy_string));
+ external_delegate_->DidAcceptSuggestion(
+ dummy_string,
+ WebAutofillClient::MenuItemIDAutocompleteEntry);
+}
+
} // namespace autofill

Powered by Google App Engine
This is Rietveld 408576698