Abstracted AutofillMsg_SetNodeText IPC out of core autofill code.

components/autofill/content/browser/autofill_driver_impl_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 126 matching lines @@
       return false;
     Tuple1<std::vector<FormDataPredictions> > autofill_param;
     AutofillMsg_FieldTypePredictionsAvailable::Read(message, &autofill_param);
     if (predictions)
       *predictions = autofill_param.a;
 
     process()->sink().ClearMessages();
     return true;
   }
 
+  // Searches for an |AutofillMsg_SetNodeText| message in the queue  of sent IPC
+  // messages. If none is present, returns false. Otherwise, extracts the first
+  // |AutofillMsg_SetNodeText| message, fills the output parameter with the
+  // value of the message's parameter, and clears the queue of sent messages.
+  bool GetSetNodeText(base::string16* value) {

[jif-google, 2013/11/13 08:24:45]

GetSetNodeText could be factored with GetAcceptDataListSuggestion in a method
that in addition to |value| takes a |msgID| and a function pointer to read the
message, but I don't think the added complexity is worth it.
WDYT?

[blundell, 2013/11/13 11:55:45]

I think it would be worth doing a |GetValueFromMessageWithID(uint32 msgID,
base::string16* value)| and then does a switch on the message ID to read
|autofill_param|. Seems like a good middle ground between avoiding code
duplication and not wanting to deal with function pointers.

On 2013/11/13 08:24:45, jif wrote:

[jif-google, 2013/11/13 14:20:25]

Done.

+    const uint32 kMsgID = AutofillMsg_SetNodeText::ID;
+    const IPC::Message* message =
+        process()->sink().GetFirstMessageMatching(kMsgID);
+    if (!message)
+      return false;
+    Tuple1<base::string16> autofill_param;
+    AutofillMsg_SetNodeText::Read(message, &autofill_param);
+    if (value)
+      *value = autofill_param.a;
+    process()->sink().ClearMessages();
+    return true;
+  }
+
   // Searches for a message matching |messageID| in the queue of sent IPC
   // messages. If none is present, returns false. Otherwise, clears the queue
   // of sent messages and returns true.
   bool HasMessageMatchingID(uint32 messageID) {
     const IPC::Message* message =
         process()->sink().GetFirstMessageMatching(messageID);
     if (!message)
       return false;
     process()->sink().ClearMessages();
     return true;
@@ skipping 85 matching lines @@
 TEST_F(AutofillDriverImplTest, ClearFilledFormSentToRenderer) {
   driver_->RendererShouldClearFilledForm();
   EXPECT_TRUE(HasMessageMatchingID(AutofillMsg_ClearForm::ID));
 }
 
 TEST_F(AutofillDriverImplTest, ClearPreviewedFormSentToRenderer) {
   driver_->RendererShouldClearPreviewedForm();
   EXPECT_TRUE(HasMessageMatchingID(AutofillMsg_ClearPreviewedForm::ID));
 }
 
+TEST_F(AutofillDriverImplTest, SetNodeText) {
+  base::string16 inputValue(UTF8ToUTF16("barqux"));
+  base::string16 outputValue;
+  driver_->RendererShouldSetNodeText(inputValue);
+  EXPECT_TRUE(GetSetNodeText(&outputValue));
+  EXPECT_EQ(inputValue, outputValue);
+}
+
 }  // namespace autofill