Issue 69293005: Experimental parser: add catch all rule

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 69293005: Experimental parser: add catch all rule (Closed)

Created:
7 years, 1 month ago by dcarney

Modified:
7 years, 1 month ago

Reviewers:
marja

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/parser

Visibility:
Public.

More Reviews

Description

Experimental parser: add catch all rule TBR=marja@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=17628

Patch Set 1 #

Total comments: 2

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+119 lines, -61 lines)			Patch
M	src/lexer/lexer_py.re	View	2 chunks	+14 lines, -13 lines	2 comments	Download
M	tools/lexer_generator/automata_test.py	View	1 chunk	+6 lines, -10 lines	0 comments	Download
M	tools/lexer_generator/dfa.py	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/lexer_generator/generator.py	View	2 chunks	+8 lines, -4 lines	0 comments	Download
M	tools/lexer_generator/nfa.py	View	5 chunks	+35 lines, -15 lines	0 comments	Download
M	tools/lexer_generator/regex_lexer.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/lexer_generator/rule_lexer.py	View	2 chunks	+7 lines, -4 lines	0 comments	Download
M	tools/lexer_generator/rule_parser.py	View	3 chunks	+8 lines, -3 lines	0 comments	Download
M	tools/lexer_generator/rule_parser_test.py	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	tools/lexer_generator/transition_keys.py	View	6 chunks	+32 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dcarney

Committed patchset #1 manually as r17628 (presubmit successful).

7 years, 1 month ago (2013-11-12 07:12:47 UTC) #1

marja

https://codereview.chromium.org/69293005/diff/1/src/lexer/lexer_py.re File src/lexer/lexer_py.re (right): https://codereview.chromium.org/69293005/diff/1/src/lexer/lexer_py.re#newcode208 src/lexer/lexer_py.re:208: /-./ <<continue>> Why are these two needed?

7 years, 1 month ago (2013-11-12 08:44:59 UTC) #2

dcarney

7 years, 1 month ago (2013-11-12 09:03:58 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/69293005/diff/1/src/lexer/lexer_py.re
File src/lexer/lexer_py.re (right):

https://codereview.chromium.org/69293005/diff/1/src/lexer/lexer_py.re#newcode208
src/lexer/lexer_py.re:208: /-./             <<continue>>
On 2013/11/12 08:45:02, marja wrote:
> Why are these two needed?

otherwise the string "<!-- --k" would produce an illegal token when it got to
the "--k"  it's kind of ugly.  if there's a lot of need for it, we can produce
some kind of syntax to handle better

Expand Messages | Collapse Messages