Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 692913003: Add skimage expectations for GalaxyS4. (Closed)

Created:
6 years, 1 month ago by scroggo
Modified:
6 years, 1 month ago
Reviewers:
borenet, stephana
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Add skimage expectations for GalaxyS4. Fixes build. Committed: https://skia.googlesource.com/skia/+/43d5debc84a4ab7e5b6143d526e8694fd7ea8324

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+218 lines, -218 lines) Patch
M expectations/skimage/Test-Android-GalaxyS4-SGX544-Arm7-Debug/expected-results.json View 1 21 chunks +109 lines, -109 lines 0 comments Download
M expectations/skimage/Test-Android-GalaxyS4-SGX544-Arm7-Release/expected-results.json View 1 21 chunks +109 lines, -109 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
scroggo
What seems strange to me is that these files are new not changed. The bot ...
6 years, 1 month ago (2014-10-30 17:34:20 UTC) #2
borenet
Rubber stamp LGTM. Probably needs to be rebased on top of https://codereview.chromium.org/683853006/
6 years, 1 month ago (2014-10-30 17:42:47 UTC) #3
scroggo
On 2014/10/30 17:42:47, borenet wrote: > Rubber stamp LGTM. Probably needs to be rebased on ...
6 years, 1 month ago (2014-10-30 17:44:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692913003/20001
6 years, 1 month ago (2014-10-30 17:45:24 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 18:44:31 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 43d5debc84a4ab7e5b6143d526e8694fd7ea8324

Powered by Google App Engine
This is Rietveld 408576698