Issue 69283002: Revert "Mojo: Add BindingsSupportImpl on top of HandleWatcher"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 69283002: Revert "Mojo: Add BindingsSupportImpl on top of HandleWatcher" (Closed)

Created:
7 years, 1 month ago by darin (slow to review)

Modified:
7 years, 1 month ago

Reviewers:

CC:
chromium-reviews, Aaron Boodman, viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Revert "Mojo: Add BindingsSupportImpl on top of HandleWatcher" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234252

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+81 lines, -230 lines)			Patch
D	mojo/common/bindings_support_impl.h	View	1 chunk	+0 lines, -39 lines	0 comments	Download
D	mojo/common/bindings_support_impl.cc	View	1 chunk	+0 lines, -65 lines	0 comments	Download
M	mojo/common/handle_watcher.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	mojo/common/handle_watcher.cc	View	7 chunks	+11 lines, -15 lines	0 comments	Download
M	mojo/common/handle_watcher_unittest.cc	View	3 chunks	+3 lines, -30 lines	0 comments	Download
M	mojo/mojo.gyp	View	3 chunks	+0 lines, -4 lines	0 comments	Download
M	mojo/public/bindings/lib/bindings_support.h	View	1 chunk	+10 lines, -18 lines	0 comments	Download
M	mojo/public/bindings/lib/connector.h	View	2 chunks	+2 lines, -5 lines	0 comments	Download
M	mojo/public/bindings/lib/connector.cc	View	5 chunks	+25 lines, -16 lines	0 comments	Download
M	mojo/public/tests/simple_bindings_support.h	View	2 chunks	+7 lines, -6 lines	0 comments	Download
M	mojo/public/tests/simple_bindings_support.cc	View	1 chunk	+21 lines, -26 lines	0 comments	Download
M	mojo/shell/context.h	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	mojo/shell/context.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 1 (0 generated)

Message was sent while issue was closed.

Committed patchset #1 manually as r234252.