Issue 692823003: java: Fix findbugs errors on generated code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 692823003: java: Fix findbugs errors on generated code. (Closed)

Created:
6 years, 1 month ago by qsr

Modified:
6 years, 1 month ago

Reviewers:
ppi

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

java: Fix findbugs errors on generated code. R=ppi@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/7f44752c57cc73ae4b5e7a5f28ffbffec0ecee28

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -3 lines)			Patch
	M	mojo/public/tools/bindings/generators/java_templates/struct_definition.tmpl	View		2 chunks	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

qsr

6 years, 1 month ago (2014-10-30 11:36:07 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7f44752c57cc73ae4b5e7a5f28ffbffec0ecee28 (presubmit successful).

Expand Messages | Collapse Messages