DescriptionFor multiline text use the maximum of the string height and the line height while calculating the height of the text being displayed.
The current code in the Canvas::SizeStringFloat function uses the passed in line_height while calculating the total
height for multiline text. This works for all cases except for DirectWrite where in the text height is a touch bigger
leading to it getting clipped. Example where this breaks is in the message center notifications where the line height
is hardcoded to 18. We could fix notification views. However it seems like fixing canvas_skia would be better.
BUG=429108
Committed: https://crrev.com/a0b11455d6dcf2fd59df7b97e1c6c850b1a63bf6
Cr-Commit-Position: refs/heads/master@{#302704}
Patch Set 1 #Patch Set 2 : Fixed build error #Messages
Total messages: 8 (2 generated)
|