Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1059)

Issue 692803004: For multiline text use the maximum of the string height and the line height while calculating the h… (Closed)

Created:
6 years, 1 month ago by ananta
Modified:
6 years, 1 month ago
Reviewers:
sky, scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

For multiline text use the maximum of the string height and the line height while calculating the height of the text being displayed. The current code in the Canvas::SizeStringFloat function uses the passed in line_height while calculating the total height for multiline text. This works for all cases except for DirectWrite where in the text height is a touch bigger leading to it getting clipped. Example where this breaks is in the message center notifications where the line height is hardcoded to 18. We could fix notification views. However it seems like fixing canvas_skia would be better. BUG=429108 Committed: https://crrev.com/a0b11455d6dcf2fd59df7b97e1c6c850b1a63bf6 Cr-Commit-Position: refs/heads/master@{#302704}

Patch Set 1 #

Patch Set 2 : Fixed build error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ui/gfx/canvas_skia.cc View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
ananta
6 years, 1 month ago (2014-11-04 00:39:41 UTC) #2
scottmg
lgtm? I don't really understand the difference between the two values though, so take that ...
6 years, 1 month ago (2014-11-04 00:45:45 UTC) #3
sky
LGTM
6 years, 1 month ago (2014-11-04 03:27:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692803004/20001
6 years, 1 month ago (2014-11-04 22:28:56 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-04 23:24:09 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-04 23:24:40 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a0b11455d6dcf2fd59df7b97e1c6c850b1a63bf6
Cr-Commit-Position: refs/heads/master@{#302704}

Powered by Google App Engine
This is Rietveld 408576698