Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 692803003: tell our grcontext to abandon its backend (Closed)

Created:
6 years, 1 month ago by reed1
Modified:
6 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

tell our grcontext to abandon its backend BUG=skia: Committed: https://skia.googlesource.com/skia/+/789e327ad9c9f7d25b2368b4f3f9812bf9f0a3a2

Patch Set 1 #

Total comments: 1

Patch Set 2 : call unref #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M samplecode/SampleApp.cpp View 1 1 chunk +6 lines, -2 lines 0 comments Download
M src/views/mac/SkNSView.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
reed1
6 years, 1 month ago (2014-10-30 14:01:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692803003/1
6 years, 1 month ago (2014-10-30 14:01:36 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-10-30 14:01:37 UTC) #5
robertphillips
https://codereview.chromium.org/692803003/diff/1/samplecode/SampleApp.cpp File samplecode/SampleApp.cpp (right): https://codereview.chromium.org/692803003/diff/1/samplecode/SampleApp.cpp#newcode264 samplecode/SampleApp.cpp:264: fCurContext->abandonContext(); I think we still need to unref this ...
6 years, 1 month ago (2014-10-30 14:18:05 UTC) #6
reed1
On 2014/10/30 14:18:05, robertphillips wrote: > https://codereview.chromium.org/692803003/diff/1/samplecode/SampleApp.cpp > File samplecode/SampleApp.cpp (right): > > https://codereview.chromium.org/692803003/diff/1/samplecode/SampleApp.cpp#newcode264 > ...
6 years, 1 month ago (2014-10-30 14:36:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692803003/20001
6 years, 1 month ago (2014-10-30 14:38:49 UTC) #10
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
6 years, 1 month ago (2014-10-30 14:38:50 UTC) #11
bsalomon
lgtm
6 years, 1 month ago (2014-10-30 14:50:53 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 18:29:13 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 789e327ad9c9f7d25b2368b4f3f9812bf9f0a3a2

Powered by Google App Engine
This is Rietveld 408576698