Issue 6928010: Make the marking stack into a deque

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6928010: Make the marking stack into a deque (Closed)

Created:
9 years, 7 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/gc/

Visibility:
Public.

Description

Make the marking stack into a deque Committed: http://code.google.com/p/v8/source/detail?r=7791

Patch Set 1 #

Total comments: 2

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+145 lines, -107 lines)			Patch
M	src/heap.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/incremental-marking.h	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/incremental-marking.cc	View	7 chunks	+31 lines, -26 lines	0 comments	Download
M	src/incremental-marking-inl.h	View	3 chunks	+8 lines, -7 lines	0 comments	Download
M	src/mark-compact.h	View	4 chunks	+51 lines, -26 lines	1 comment	Download
M	src/mark-compact.cc	View	12 chunks	+39 lines, -39 lines	0 comments	Download
M	src/spaces.h	View	3 chunks	+5 lines, -1 line	1 comment	Download
M	src/spaces.cc	View	2 chunks	+3 lines, -0 lines	0 comments	Download
M	test/cctest/test-mark-compact.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

9 years, 7 months ago (2011-05-04 14:46:52 UTC) #2

LGTM

http://codereview.chromium.org/6928010/diff/1/src/mark-compact.h
File src/mark-compact.h (right):

http://codereview.chromium.org/6928010/diff/1/src/mark-compact.h#newcode140
src/mark-compact.h:140: if (size > obj_high - obj_low) size >>= 1;
(obj_high - obj_low)

http://codereview.chromium.org/6928010/diff/1/src/spaces.h
File src/spaces.h (right):

http://codereview.chromium.org/6928010/diff/1/src/spaces.h#newcode343
src/spaces.h:343: bool in_new_space() { return in_new_space_; }
please revert these unrelated changes.

Expand Messages | Collapse Messages