Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 692793002: [unpacker] Allow only one ZIP handler at once: either the new or the old one. (Closed)

Created:
6 years, 1 month ago by mtomasz
Modified:
6 years, 1 month ago
Reviewers:
fukino
CC:
chromium-reviews, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[unpacker] Allow only one ZIP handler at once: either the new or the old one. If the new ZIP unpacker flow is enabled, then it the previous avfs based logic should be hidden from user. And the other way the same. TEST=Tested manually with the flag enabled and disabled. BUG=427778 Committed: https://crrev.com/a5776f154ac000c7ce301227ecf5ccf748ab1650 Cr-Commit-Position: refs/heads/master@{#302265}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M chrome/browser/chromeos/file_manager/file_browser_handlers.cc View 4 chunks +15 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/file_manager/file_tasks.cc View 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mtomasz
@fukino: PTAL. Thanks!
6 years, 1 month ago (2014-10-30 08:02:58 UTC) #2
fukino
On 2014/10/30 08:02:58, mtomasz wrote: > @fukino: PTAL. Thanks! lgtm.
6 years, 1 month ago (2014-10-31 13:57:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692793002/1
6 years, 1 month ago (2014-10-31 13:58:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-31 14:41:21 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 14:41:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a5776f154ac000c7ce301227ecf5ccf748ab1650
Cr-Commit-Position: refs/heads/master@{#302265}

Powered by Google App Engine
This is Rietveld 408576698