Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 692763002: Add Layouttest for importing keys with invalid usages (Closed)

Created:
6 years, 1 month ago by xun.sun
Modified:
6 years, 1 month ago
Reviewers:
eroman
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add Layouttest for importing keys with invalid usages BUG=425651 R=eroman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184849

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rename and revert to the simple one line change approach #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -1 line) Patch
M LayoutTests/crypto/resources/keys.js View 1 chunk +21 lines, -1 line 0 comments Download
A LayoutTests/crypto/rsa-importKey-badUsages.html View 1 1 chunk +75 lines, -0 lines 0 comments Download
A LayoutTests/crypto/rsa-importKey-badUsages-expected.txt View 1 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
eroman
https://codereview.chromium.org/692763002/diff/1/LayoutTests/crypto/rsa-importKey-failures.html File LayoutTests/crypto/rsa-importKey-failures.html (right): https://codereview.chromium.org/692763002/diff/1/LayoutTests/crypto/rsa-importKey-failures.html#newcode1 LayoutTests/crypto/rsa-importKey-failures.html:1: <!DOCTYPE html> Can you rename the file to describe ...
6 years, 1 month ago (2014-10-30 19:13:07 UTC) #1
xun.sun
On 2014/10/30 19:13:07, eroman wrote: > https://codereview.chromium.org/692763002/diff/1/LayoutTests/crypto/rsa-importKey-failures.html > File LayoutTests/crypto/rsa-importKey-failures.html (right): > > https://codereview.chromium.org/692763002/diff/1/LayoutTests/crypto/rsa-importKey-failures.html#newcode1 > ...
6 years, 1 month ago (2014-10-31 05:41:59 UTC) #2
eroman
lgtm
6 years, 1 month ago (2014-11-04 20:36:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692763002/20001
6 years, 1 month ago (2014-11-05 00:00:15 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 02:24:55 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 184849

Powered by Google App Engine
This is Rietveld 408576698