Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3442)

Unified Diff: chrome/renderer/printing/print_web_view_helper.cc

Issue 692733003: Compile Android using GRIT's new --no-output-all-resource-defines flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: use --no-output-all-resource-defines Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | ui/resources/ui_resources.grd » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/printing/print_web_view_helper.cc
diff --git a/chrome/renderer/printing/print_web_view_helper.cc b/chrome/renderer/printing/print_web_view_helper.cc
index cd318a23956851c0337b17716dfce50090de5f6a..7b1be8086ac1b7fac7d24dc33b979fd3e9da6b75 100644
--- a/chrome/renderer/printing/print_web_view_helper.cc
+++ b/chrome/renderer/printing/print_web_view_helper.cc
@@ -471,7 +471,7 @@ void PrintWebViewHelper::PrintHeaderAndFooter(
web_view->setMainFrame(frame);
base::StringValue html(ResourceBundle::GetSharedInstance().GetLocalizedString(
- IDR_PRINT_PREVIEW_PAGE));
+ 0));//IDR_PRINT_PREVIEW_PAGE));
newt (away) 2014/11/06 09:13:03 IDR_PRINT_PREVIEW_PAGE is defined in chrome/browse
Vitaly Buka (NO REVIEWS) 2014/11/06 09:38:02 PrintWebViewHelper::PrintHeaderAndFooter should no
Vitaly Buka (NO REVIEWS) 2014/11/06 09:48:18 or just disable PrintWebViewHelper::PrintHeaderAnd
// Load page with script to avoid async operations.
ExecuteScript(frame, kPageLoadScriptFormat, html);
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | ui/resources/ui_resources.grd » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698