chrome/browser/resources_util_unittest.cc - Issue 692733003: Compile Android using GRIT's new --no-output-all-resource-defines flag.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources_util_unittest.cc

Issue 692733003: Compile Android using GRIT's new --no-output-all-resource-defines flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: use --no-output-all-resource-defines Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources_util_unittest.cc

diff --git a/chrome/browser/resources_util_unittest.cc b/chrome/browser/resources_util_unittest.cc

index fd48563e54cbab7a33115c6f193b480b50ac37c6..74a31f33cdc660c377dc40808d1d6031a244d1af 100644

--- a/chrome/browser/resources_util_unittest.cc

+++ b/chrome/browser/resources_util_unittest.cc

@@ -18,8 +18,8 @@ TEST(ResourcesUtil, SpotCheckIds) {

int id;

} kCases[] = {

// IDRs from chrome/app/theme/theme_resources.grd should be valid.

- {"IDR_BACK", IDR_BACK},

- {"IDR_STOP", IDR_STOP},

+ {"IDR_INFOBAR_COOKIE", IDR_INFOBAR_COOKIE},

+ {"IDR_PAGEINFO_BAD", IDR_PAGEINFO_BAD},

// IDRs from ui/resources/ui_resources.grd should be valid.

{"IDR_CHECKMARK", IDR_CHECKMARK},

{"IDR_THROBBER", IDR_THROBBER},

« no previous file with comments | « build/common.gypi ('k') | chrome/browser/search/instant_service.cc » ('j') | chrome/renderer/printing/print_web_view_helper.cc » ('J')