Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Side by Side Diff: chrome/browser/resources_util_unittest.cc

Issue 692733003: Compile Android using GRIT's new --no-output-all-resource-defines flag. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: merged two ifdefs Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/common.gypi ('k') | chrome/browser/search/instant_service.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/resources_util.h" 5 #include "chrome/browser/resources_util.h"
6 6
7 #include "grit/theme_resources.h" 7 #include "grit/theme_resources.h"
8 #include "testing/gtest/include/gtest/gtest.h" 8 #include "testing/gtest/include/gtest/gtest.h"
9 #include "ui/resources/grit/ui_resources.h" 9 #include "ui/resources/grit/ui_resources.h"
10 10
11 #if defined(OS_CHROMEOS) 11 #if defined(OS_CHROMEOS)
12 #include "grit/ui_chromeos_resources.h" 12 #include "grit/ui_chromeos_resources.h"
13 #endif 13 #endif
14 14
15 TEST(ResourcesUtil, SpotCheckIds) { 15 TEST(ResourcesUtil, SpotCheckIds) {
16 const struct { 16 const struct {
17 const char* name; 17 const char* name;
18 int id; 18 int id;
19 } kCases[] = { 19 } kCases[] = {
20 // IDRs from chrome/app/theme/theme_resources.grd should be valid. 20 // IDRs from chrome/app/theme/theme_resources.grd should be valid.
21 {"IDR_BACK", IDR_BACK}, 21 {"IDR_INFOBAR_COOKIE", IDR_INFOBAR_COOKIE},
22 {"IDR_STOP", IDR_STOP}, 22 {"IDR_PAGEINFO_BAD", IDR_PAGEINFO_BAD},
23 // IDRs from ui/resources/ui_resources.grd should be valid. 23 // IDRs from ui/resources/ui_resources.grd should be valid.
24 {"IDR_CHECKMARK", IDR_CHECKMARK}, 24 {"IDR_CHECKMARK", IDR_CHECKMARK},
25 {"IDR_THROBBER", IDR_THROBBER}, 25 {"IDR_THROBBER", IDR_THROBBER},
26 #if defined(OS_CHROMEOS) 26 #if defined(OS_CHROMEOS)
27 // Check IDRs from ui/chromeos/resources/ui_chromeos_resources.grd. 27 // Check IDRs from ui/chromeos/resources/ui_chromeos_resources.grd.
28 {"IDR_LOGIN_DEFAULT_USER", IDR_LOGIN_DEFAULT_USER}, 28 {"IDR_LOGIN_DEFAULT_USER", IDR_LOGIN_DEFAULT_USER},
29 #endif 29 #endif
30 // Unknown names should be invalid and return -1. 30 // Unknown names should be invalid and return -1.
31 {"foobar", -1}, 31 {"foobar", -1},
32 {"backstar", -1}, 32 {"backstar", -1},
33 }; 33 };
34 34
35 for (size_t i = 0; i < arraysize(kCases); ++i) 35 for (size_t i = 0; i < arraysize(kCases); ++i)
36 EXPECT_EQ(kCases[i].id, ResourcesUtil::GetThemeResourceId(kCases[i].name)); 36 EXPECT_EQ(kCases[i].id, ResourcesUtil::GetThemeResourceId(kCases[i].name));
37 } 37 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | chrome/browser/search/instant_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698