Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(925)

Unified Diff: ui/base/ime/remote_input_method_win_unittest.cc

Issue 692713002: Add a few missing overrides found by a new clang warning. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/ime/remote_input_method_win_unittest.cc
diff --git a/ui/base/ime/remote_input_method_win_unittest.cc b/ui/base/ime/remote_input_method_win_unittest.cc
index 5cf8aa3db992db6b29fee6fdea03556ccfe6174d..cccc5e4a3457dc34ebefbb5347fde2e98b7d55e3 100644
--- a/ui/base/ime/remote_input_method_win_unittest.cc
+++ b/ui/base/ime/remote_input_method_win_unittest.cc
@@ -104,9 +104,7 @@ class MockTextInputClient : public DummyTextInputClient {
virtual ui::TextInputMode GetTextInputMode() const override {
return text_input_mode_;
}
- virtual gfx::Rect GetCaretBounds() const {
- return caret_bounds_;
- }
+ virtual gfx::Rect GetCaretBounds() const override { return caret_bounds_; }
virtual bool GetCompositionCharacterBounds(uint32 index,
gfx::Rect* rect) const override {
// Emulate the situation of crbug.com/328237.
@@ -251,8 +249,7 @@ class MockInputMethodObserver : public InputMethodObserver {
virtual void OnInputMethodDestroyed(const InputMethod* client) override {
++on_input_method_destroyed_changed_;
}
- virtual void OnShowImeIfNeeded() {
- }
+ virtual void OnShowImeIfNeeded() override {}
size_t on_text_input_state_changed_;
size_t on_input_method_destroyed_changed_;

Powered by Google App Engine
This is Rietveld 408576698