Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 692713002: Add a few missing overrides found by a new clang warning. (Closed)

Created:
6 years, 1 month ago by Nico
Modified:
6 years, 1 month ago
Reviewers:
sky
CC:
chromium-reviews, yusukes+watch_chromium.org, plundblad+watch_chromium.org, yukishiino+watch_chromium.org, aboxhall+watch_chromium.org, tfarina, penghuang+watch_chromium.org, yuzo+watch_chromium.org, nona+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ui: Add a few missing overrides found by a new clang warning. Namely, -Winconsistent-missing-override. While here, also remove "virtual" from overridden methods, as per new style. No behavior change. BUG=428099 Committed: https://crrev.com/4ec660f9904a722cfac0226b684cd6f4787ece07 Cr-Commit-Position: refs/heads/master@{#302035}

Patch Set 1 #

Total comments: 2

Patch Set 2 : novirt #

Unified diffs Side-by-side diffs Delta from patch set Stats (+159 lines, -164 lines) Patch
M ui/base/dragdrop/os_exchange_data_provider_win.h View 1 1 chunk +37 lines, -37 lines 0 comments Download
M ui/base/ime/remote_input_method_win_unittest.cc View 1 5 chunks +22 lines, -32 lines 0 comments Download
M ui/gl/gl_surface_glx.h View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/accessibility/native_view_accessibility_win.h View 1 4 chunks +99 lines, -94 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
Nico
I present: The most boring cl you'll see today!
6 years, 1 month ago (2014-10-30 00:44:05 UTC) #2
sky
https://codereview.chromium.org/692713002/diff/1/ui/base/dragdrop/os_exchange_data_provider_win.h File ui/base/dragdrop/os_exchange_data_provider_win.h (right): https://codereview.chromium.org/692713002/diff/1/ui/base/dragdrop/os_exchange_data_provider_win.h#newcode150 ui/base/dragdrop/os_exchange_data_provider_win.h:150: // OSExchangeData::Provider methods. I thought we were getting rid ...
6 years, 1 month ago (2014-10-30 00:59:10 UTC) #3
Nico
https://codereview.chromium.org/692713002/diff/1/ui/base/dragdrop/os_exchange_data_provider_win.h File ui/base/dragdrop/os_exchange_data_provider_win.h (right): https://codereview.chromium.org/692713002/diff/1/ui/base/dragdrop/os_exchange_data_provider_win.h#newcode150 ui/base/dragdrop/os_exchange_data_provider_win.h:150: // OSExchangeData::Provider methods. On 2014/10/30 00:59:10, sky wrote: > ...
6 years, 1 month ago (2014-10-30 01:00:01 UTC) #4
dcheng
On 2014/10/30 01:00:01, Nico wrote: > https://codereview.chromium.org/692713002/diff/1/ui/base/dragdrop/os_exchange_data_provider_win.h > File ui/base/dragdrop/os_exchange_data_provider_win.h (right): > > https://codereview.chromium.org/692713002/diff/1/ui/base/dragdrop/os_exchange_data_provider_win.h#newcode150 > ...
6 years, 1 month ago (2014-10-30 01:04:25 UTC) #5
Nico
Removed the virtuals
6 years, 1 month ago (2014-10-30 02:56:05 UTC) #6
sky
LGTM
6 years, 1 month ago (2014-10-30 03:16:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692713002/20001
6 years, 1 month ago (2014-10-30 04:19:41 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-10-30 05:01:33 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 05:02:18 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4ec660f9904a722cfac0226b684cd6f4787ece07
Cr-Commit-Position: refs/heads/master@{#302035}

Powered by Google App Engine
This is Rietveld 408576698