Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 692703002: Fix the DontSwapProcessWithOnlyRelNoreferrer test for --site-per-process (Closed)

Created:
6 years, 1 month ago by alexmos
Modified:
6 years, 1 month ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix the DontSwapProcessWithOnlyRelNoreferrer test for --site-per-process. This test checks that following a cross-site link with rel="nofererrer" does not create a new SiteInstance per https://crbug.com/24447. However, the test expectations should change with --site-per-process, as we do expect a process swap in this mode. This is similar to how DontSwapProcessWithOnlyTargetBlank behaves (https://codereview.chromium.org/635933002/). BUG=417518 Committed: https://crrev.com/347a917ac2b308dda446ce51c616fa1720adcfb8 Cr-Commit-Position: refs/heads/master@{#302103}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M content/browser/frame_host/render_frame_host_manager_browsertest.cc View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
alexmos
Charlie, could you please take a look?
6 years, 1 month ago (2014-10-30 16:54:20 UTC) #2
Charlie Reis
LGTM.
6 years, 1 month ago (2014-10-30 16:58:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692703002/1
6 years, 1 month ago (2014-10-30 17:02:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 17:43:37 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 17:44:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/347a917ac2b308dda446ce51c616fa1720adcfb8
Cr-Commit-Position: refs/heads/master@{#302103}

Powered by Google App Engine
This is Rietveld 408576698