Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 6927022: Turn off the search engine selector for the Russian locale. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 5 months ago by Miranda Callahan
Modified:
6 years ago
CC:
chromium-reviews
Visibility:
Public.

Description

Turn off the search engine selector for the Russian locale. BUG=81578 TEST=no search engine selector in organic builds in Russian locale. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=84235

Patch Set 1 : '' #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M chrome/browser/first_run/first_run.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/first_run/first_run.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/first_run_dialog.mm View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/first_run_dialog.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/first_run_search_engine_view.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 7 (0 generated)
Miranda Callahan
6 years, 5 months ago (2011-05-04 20:05:57 UTC) #1
Avi (ping after 24h)
http://codereview.chromium.org/6927022/diff/5006/chrome/browser/first_run/first_run.h File chrome/browser/first_run/first_run.h (right): http://codereview.chromium.org/6927022/diff/5006/chrome/browser/first_run/first_run.h#newcode146 chrome/browser/first_run/first_run.h:146: static bool SearchEngineSelectorRestricted(); Naming not obvious. Please rename to ...
6 years, 5 months ago (2011-05-04 20:13:06 UTC) #2
Miranda Callahan
http://codereview.chromium.org/6927022/diff/5006/chrome/browser/first_run/first_run.h File chrome/browser/first_run/first_run.h (right): http://codereview.chromium.org/6927022/diff/5006/chrome/browser/first_run/first_run.h#newcode146 chrome/browser/first_run/first_run.h:146: static bool SearchEngineSelectorRestricted(); On 2011/05/04 20:13:06, Avi wrote: > ...
6 years, 5 months ago (2011-05-04 20:15:31 UTC) #3
Avi (ping after 24h)
LGTM
6 years, 5 months ago (2011-05-04 20:29:33 UTC) #4
Gordjelin
What the help this patch is?? Why ever you needed to block the selection dialog ...
6 years ago (2011-10-02 21:57:32 UTC) #5
Gennady K
On 2011/10/02 21:57:32, Gordjelin wrote: > What the help this patch is?? Why ever you ...
6 years ago (2011-10-03 00:02:31 UTC) #6
Gennady K
6 years ago (2011-10-03 00:13:37 UTC) #7

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 81bcdb8aa