Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 692693002: Make it possible to change the viewport size (Closed)

Created:
6 years, 1 month ago by eseidel
Modified:
6 years, 1 month ago
Reviewers:
sky
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Make it possible to change the viewport size This makes it possible to change the viewport size which mojo is using. The sky debugger uses this new API to set the viewport to something closer to mobile instead of 800x600 ancient desktop size. :) Still the (800, 600) constant is prevelant throughout mojo (just search for it) and mojo does not seem to fully update when the viewport size changes, so we actually only see 320x600 pixels instead of 320x640 in sky debugger after this change. Mostly this change is about validating that this is the correct way to plumb this information. R=sky@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/6a7fabed4d6c8ddfbc932b2bd6d36d20e6337b2a

Patch Set 1 #

Total comments: 5

Patch Set 2 : Fix style nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -7 lines) Patch
M mojo/services/public/interfaces/window_manager/window_manager_internal.mojom View 2 chunks +4 lines, -0 lines 0 comments Download
M mojo/services/view_manager/connection_manager.h View 1 1 chunk +7 lines, -7 lines 0 comments Download
M mojo/services/view_manager/connection_manager.cc View 3 chunks +10 lines, -0 lines 0 comments Download
M mojo/services/view_manager/display_manager.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/services/view_manager/display_manager.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/services/window_manager/window_manager_app.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/services/window_manager/window_manager_app.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M sky/tools/debugger/debugger.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
eseidel
6 years, 1 month ago (2014-10-30 00:10:02 UTC) #1
sky
LGTM with the following addressed. And yes, this is the route I was thinking. https://codereview.chromium.org/692693002/diff/1/mojo/services/view_manager/connection_manager.h ...
6 years, 1 month ago (2014-10-30 03:23:57 UTC) #2
eseidel
6 years, 1 month ago (2014-10-30 21:20:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6a7fabed4d6c8ddfbc932b2bd6d36d20e6337b2a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698