Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: ppapi/proxy/plugin_dispatcher.h

Issue 692683003: Hold the Pepper proxy lock for all Pepper GL calls. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove virtual for override functions Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ppapi/proxy/plugin_dispatcher.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/plugin_dispatcher.h
diff --git a/ppapi/proxy/plugin_dispatcher.h b/ppapi/proxy/plugin_dispatcher.h
index f8e22f6ebdedb69ce9c8eaaeb77199aa80a5e071..bb64b82d2f9093d52b76a262fdc1077f5735603b 100644
--- a/ppapi/proxy/plugin_dispatcher.h
+++ b/ppapi/proxy/plugin_dispatcher.h
@@ -140,12 +140,15 @@ class PPAPI_PROXY_EXPORT PluginDispatcher
bool is_client);
// Dispatcher overrides.
- virtual bool IsPlugin() const;
- virtual bool Send(IPC::Message* msg);
+ bool IsPlugin() const override;
+ bool Send(IPC::Message* msg) override;
+ // Unlike |Send()|, this function continues to hold the Pepper proxy lock
+ // unconditionally.
+ bool SendAndStayLocked(IPC::Message* msg) override;
// IPC::Listener implementation.
- virtual bool OnMessageReceived(const IPC::Message& msg);
- virtual void OnChannelError();
+ bool OnMessageReceived(const IPC::Message& msg) override;
+ void OnChannelError() override;
// Keeps track of which dispatcher to use for each instance, active instances
// and tracks associated data like the current size.
« no previous file with comments | « no previous file | ppapi/proxy/plugin_dispatcher.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698