content/renderer/accessibility/blink_ax_tree_source.cc - Issue 692643005: ARIA state/property(aria-relevant,aria-busy) are not exposed correctly on MAC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/accessibility/blink_ax_tree_source.cc

Issue 692643005: ARIA state/property(aria-relevant,aria-busy) are not exposed correctly on MAC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporating comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/accessibility/browser_accessibility_cocoa.mm ('k') | content/test/data/accessibility/aria-busy-expected-mac.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/accessibility/blink_ax_tree_source.cc

diff --git a/content/renderer/accessibility/blink_ax_tree_source.cc b/content/renderer/accessibility/blink_ax_tree_source.cc

index b7092e33c4b35450e24868419735da7dd8b0e211..a383f424ee578f4c0801fbdb906b3558b92d4f62 100644

--- a/content/renderer/accessibility/blink_ax_tree_source.cc

+++ b/content/renderer/accessibility/blink_ax_tree_source.cc

@@ -372,6 +372,8 @@ void BlinkAXTreeSource::SerializeNode(blink::WebAXObject src,

if (src.isInLiveRegion()) {

dst->AddBoolAttribute(ui::AX_ATTR_LIVE_ATOMIC, src.liveRegionAtomic());

dst->AddBoolAttribute(ui::AX_ATTR_LIVE_BUSY, src.liveRegionBusy());

+ if (src.liveRegionBusy())

+ dst->state |= (1 << ui::AX_STATE_BUSY);

dst->AddStringAttribute(ui::AX_ATTR_LIVE_STATUS,

UTF16ToUTF8(src.liveRegionStatus()));

dst->AddStringAttribute(ui::AX_ATTR_LIVE_RELEVANT,