Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Unified Diff: content/browser/accessibility/browser_accessibility_cocoa.mm

Issue 692643005: ARIA state/property(aria-relevant,aria-busy) are not exposed correctly on MAC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/accessibility/browser_accessibility_cocoa.mm
diff --git a/content/browser/accessibility/browser_accessibility_cocoa.mm b/content/browser/accessibility/browser_accessibility_cocoa.mm
index 468d2ec421c29c12d465a23fcab1745bf07f4aa0..33a95c4b6dd33dbca8076ac5e76e9dceab2ca08e 100644
--- a/content/browser/accessibility/browser_accessibility_cocoa.mm
+++ b/content/browser/accessibility/browser_accessibility_cocoa.mm
@@ -151,9 +151,8 @@ NSDictionary* attributeToMethodNameMap = nil;
}
- (NSNumber*)ariaBusy {
- bool boolValue = browserAccessibility_->GetBoolAttribute(
- ui::AX_ATTR_LIVE_BUSY);
- return [NSNumber numberWithBool:boolValue];
+ return [NSNumber numberWithBool:
+ GetState(browserAccessibility_, ui::AX_STATE_BUSY)];
}
- (NSString*)ariaLive {
@@ -1327,20 +1326,30 @@ NSDictionary* attributeToMethodNameMap = nil;
ui::AX_ATTR_LIVE_STATUS)) {
[ret addObjectsFromArray:[NSArray arrayWithObjects:
@"AXARIALive",
- @"AXARIARelevant",
nil]];
}
if (browserAccessibility_->HasStringAttribute(
- ui::AX_ATTR_CONTAINER_LIVE_STATUS)) {
+ ui::AX_ATTR_LIVE_RELEVANT)) {
+ [ret addObjectsFromArray:[NSArray arrayWithObjects:
+ @"AXARIARelevant",
+ nil]];
+ }
+ if (browserAccessibility_->HasBoolAttribute(
+ ui::AX_ATTR_LIVE_ATOMIC)) {
[ret addObjectsFromArray:[NSArray arrayWithObjects:
@"AXARIAAtomic",
+ nil]];
+ }
+ if (browserAccessibility_->HasBoolAttribute(
+ ui::AX_ATTR_LIVE_BUSY)) {
+ [ret addObjectsFromArray:[NSArray arrayWithObjects:
@"AXARIABusy",
nil]];
}
//Add expanded attribute only if it has expanded or collapsed state.
- if (GetState(browserAccessibility_,ui::AX_STATE_EXPANDED) ||
- GetState(browserAccessibility_,ui::AX_STATE_COLLAPSED)) {
+ if (GetState(browserAccessibility_, ui::AX_STATE_EXPANDED) ||
+ GetState(browserAccessibility_, ui::AX_STATE_COLLAPSED)) {
[ret addObjectsFromArray:[NSArray arrayWithObjects:
NSAccessibilityExpandedAttribute,
nil]];

Powered by Google App Engine
This is Rietveld 408576698