ARIA state/property(aria-relevant,aria-busy) are not exposed correctly on MAC.

content/browser/accessibility/browser_accessibility_cocoa.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <execinfo.h>
 
 #import "content/browser/accessibility/browser_accessibility_cocoa.h"
 
 #include <map>
 
@@ skipping 1290 matching lines @@
     [ret addObjectsFromArray:[NSArray arrayWithObjects:
         NSAccessibilityURLAttribute,
         nil]];
   }
 
   // Live regions.
   if (browserAccessibility_->HasStringAttribute(
           ui::AX_ATTR_LIVE_STATUS)) {
     [ret addObjectsFromArray:[NSArray arrayWithObjects:
         @"AXARIALive",
+        nil]];
+  }
+  if (browserAccessibility_->HasStringAttribute(

[dmazzoni, 2014/11/07 21:28:43]

I'm not sure this change is needed. aria-relevant is meaningless on an element
that doesn't already have aria-live set.

[shreeramk, 2014/11/08 09:21:34]

But for ARIA role log, Specs says:
Note: Elements with the role log have an implicit aria-live value of polite.

And so, on windows without aria-live property, relevant and container-relevants
are exposed.

Do you mean to say, AXARIArelevant/relevant/container-relevant should
automatically be exposed if aria-live attribute is present and aria-relevant is
not present?(Please check aria-live.html and aria-live-expected-win.txt -
without aria-relevant, container-relevant and relevant are exposed.)

Or, expose AXARIArelevant/relevant/container-relevant only if aria-live and
aria-relevant both are present?

[dmazzoni, 2014/11/11 06:44:02]

That's correct. But we handle this in Blink, so if something has a role of log,
then ui::AX_ATTR_LIVE_STATUS should be set to "polite". If that's not what
you're getting
then we should debug that in Blink.

What I'm saying is that there should never be a case where we have aria-relevant
but we don't also have aria-live. Even if aria-live isn't set as an HTML
attribute, it should be set by Blink due to the role, so by the time we get to
browser_accessibility_cocoa.mm we should have a "live" status.

[shreeramk, 2014/11/19 03:45:36]

Yes correct its handled in blink.

I was looking into the code and found out this, (blink_ax_tree_source.cc) - from
which we can conclude that if its in live region then following attributes are
set for respective states/property(live, relevant... etc.)

if (src.isInLiveRegion()) {
    dst->AddBoolAttribute(ui::AX_ATTR_LIVE_ATOMIC, src.liveRegionAtomic());
    .
    .
    .
    dst->AddStringAttribute(ui::AX_ATTR_LIVE_RELEVANT,
                            UTF16ToUTF8(src.liveRegionRelevant()));
    dst->AddBoolAttribute(ui::AX_ATTR_CONTAINER_LIVE_ATOMIC,
                          src.containerLiveRegionAtomic());
    dst->AddStringAttribute(ui::AX_ATTR_CONTAINER_LIVE_STATUS,
                            UTF16ToUTF8(src.containerLiveRegionStatus()));
    dst->AddStringAttribute(ui::AX_ATTR_CONTAINER_LIVE_RELEVANT,
                            UTF16ToUTF8(src.containerLiveRegionRelevant()));
  }

Hence I think we should use this ui::* checks in browser_accessibility_*.cc/mm
files. 

This ui::* attributes check has been used correctly on windows, hence there
those attributes are exposed correctly, 

browser_accessibility_win.cc 

// Expose live region attributes.
  StringAttributeToIA2(ui::AX_ATTR_LIVE_STATUS, "live");
  StringAttributeToIA2(ui::AX_ATTR_LIVE_RELEVANT, "relevant");
  BoolAttributeToIA2(ui::AX_ATTR_LIVE_ATOMIC, "atomic");
  BoolAttributeToIA2(ui::AX_ATTR_LIVE_BUSY, "busy");

  // Expose container live region attributes.
  StringAttributeToIA2(ui::AX_ATTR_CONTAINER_LIVE_STATUS,
                       "container-live");
  StringAttributeToIA2(ui::AX_ATTR_CONTAINER_LIVE_RELEVANT,
                       "container-relevant");
  BoolAttributeToIA2(ui::AX_ATTR_CONTAINER_LIVE_ATOMIC,
                     "container-atomic");
  BoolAttributeToIA2(ui::AX_ATTR_CONTAINER_LIVE_BUSY,
                     "container-busy");


But on mac it has not been exposed properly due to wrong checks.

+          ui::AX_ATTR_CONTAINER_LIVE_RELEVANT)) {
+    [ret addObjectsFromArray:[NSArray arrayWithObjects:
         @"AXARIARelevant",
         nil]];
   }
   if (browserAccessibility_->HasStringAttribute(
           ui::AX_ATTR_CONTAINER_LIVE_STATUS)) {
     [ret addObjectsFromArray:[NSArray arrayWithObjects:
         @"AXARIAAtomic",
         @"AXARIABusy",
         nil]];
   }
@@ skipping 153 matching lines @@
     return [super hash];
   return browserAccessibility_->GetId();
 }
 
 - (BOOL)accessibilityShouldUseUniqueId {
   return YES;
 }
 
 @end