Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 692643003: Moves home card background to HomeCardView. (Closed)

Created:
6 years, 1 month ago by Jun Mukai
Modified:
6 years, 1 month ago
Reviewers:
oshima
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Moves home card background to HomeCardView. We'll soon remove AthenaStartPageView, so AppList independent components like background should belong to HomeCardView. This CL also fixes the bug of the visual effect; the spec is saying that the gradient end should be white even in the BOTTOM state. BUG=425717 R=oshima@chromium.org TEST=manually Committed: https://chromium.googlesource.com/chromium/src/+/edc727717b7643cef102702436b9b87238a340db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -36 lines) Patch
M athena/home/athena_start_page_view.h View 2 chunks +0 lines, -5 lines 0 comments Download
M athena/home/athena_start_page_view.cc View 5 chunks +1 line, -21 lines 0 comments Download
M athena/home/home_card_impl.cc View 5 chunks +52 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jun Mukai
6 years, 1 month ago (2014-10-30 08:17:51 UTC) #1
oshima
lgtm
6 years, 1 month ago (2014-10-30 19:59:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692643003/1
6 years, 1 month ago (2014-10-31 00:16:24 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/edc727717b7643cef102702436b9b87238a340db Cr-Commit-Position: refs/heads/master@{#302219}
6 years, 1 month ago (2014-10-31 04:29:40 UTC) #5
Jun Mukai
6 years, 1 month ago (2014-10-31 04:29:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
edc727717b7643cef102702436b9b87238a340db (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698