Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: src/IceOperand.h

Issue 692633004: Subzero: Remove Variable::NeedsStackSlot. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Also consider whether Dest needs a stack slot Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/IceOperand.h
diff --git a/src/IceOperand.h b/src/IceOperand.h
index 77fa7a30c666aecb93b5fa32f047454504281438..5e0c02d84b7f261572548c8b3bea2d1a95d2d48e 100644
--- a/src/IceOperand.h
+++ b/src/IceOperand.h
@@ -405,8 +405,6 @@ public:
void setIgnoreLiveness() { IgnoreLiveness = true; }
bool getIgnoreLiveness() const { return IgnoreLiveness; }
- bool needsStackSlot() const { return NeedsStackSlot; }
- void setNeedsStackSlot() { NeedsStackSlot = true; }
int32_t getStackOffset() const { return StackOffset; }
void setStackOffset(int32_t Offset) { StackOffset = Offset; }
@@ -483,9 +481,9 @@ public:
protected:
Variable(OperandKind K, Type Ty, SizeT Index, const IceString &Name)
: Operand(K, Ty), Number(Index), Name(Name), IsArgument(false),
- IsImplicitArgument(false), IgnoreLiveness(false), NeedsStackSlot(false),
- StackOffset(0), RegNum(NoRegister), RegNumTmp(NoRegister), Weight(1),
- LoVar(NULL), HiVar(NULL) {
+ IsImplicitArgument(false), IgnoreLiveness(false), StackOffset(0),
+ RegNum(NoRegister), RegNumTmp(NoRegister), Weight(1), LoVar(NULL),
+ HiVar(NULL) {
Vars = VarsReal;
Vars[0] = this;
NumVars = 1;
@@ -501,9 +499,6 @@ protected:
// constructing and validating live ranges. This is usually
// reserved for the stack pointer.
bool IgnoreLiveness;
- // NeedsStackSlot starts out false, and is set to true once we know
- // for sure that the variable needs a stack slot.
- bool NeedsStackSlot;
// StackOffset is the canonical location on stack (only if
// RegNum==NoRegister || IsArgument).
int32_t StackOffset;
« no previous file with comments | « src/IceCfgNode.cpp ('k') | src/IceRegAlloc.cpp » ('j') | src/IceTargetLoweringX8632.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698