Use the correct font metrics in base PlatformFontWin if DirectWrite is used in the browser for font…

Use the correct font metrics in base PlatformFontWin if DirectWrite is used in the browser for font metrics.

The PlatformFontWin class uses GDI for creating fonts and their metrics. If DirectWrite is used for
font metrics then the metrics returned by GDI for the fonts and those calculated by skia using DirectWrite
differ leading to text getting clipped etc.

DirectWrite provides an interface IDWriteGdiInterop for interoperability with GDI. Converting the GDI font
to a DirectWrite font face object (IDWriteFontFace) and then converting this back to a GDI font gives us the
correct metrics.

The other option could be to create a PlatformFontSkia class on the same lines as PlatformFontWin and use skia
to get the font metrics. The amount of work needed there is unkown. We could look at this as a possible alternative
in case the above approach does not work.

Changes in this patch are as below:-
1. We use DirectWrite to create a IDWriteFactory interface in content browser. This is passed down to skia as the
   default factory.

2. The factory created in step 1 is also passsed via a static setter function to the PlatformFontWin class. The presence
   of a non NULL IDWriteFactory interface is used by this class to create a DirectWrite metrics compatible GDI font.

3. HarfBuzz text rendering is enabled by default in the browser. The MaybeEnableDirectWriteFontRendering function now
   checks for the disable harfbuzz text rendering switch instead.

BUG=427804, 427802
Committed: https://crrev.com/9fd5754d8c121d7c6fbc5b88d361a1c3e0d03900
Cr-Commit-Position: refs/heads/master@{#301987}

[ananta, 2014-10-29 21:26:12]

ananta@chromium.org changed reviewers:
+ scottmg@chromium.org, sky@chromium.org

[scottmg, 2014-10-29 21:33:33]

lgtm

https://codereview.chromium.org/692633003/diff/1/content/browser/browser_main...
File content/browser/browser_main_runner.cc (right):

https://codereview.chromium.org/692633003/diff/1/content/browser/browser_main...
content/browser/browser_main_runner.cc:136: return;
no return

https://codereview.chromium.org/692633003/diff/1/ui/gfx/platform_font_win.cc
File ui/gfx/platform_font_win.cc (right):

https://codereview.chromium.org/692633003/diff/1/ui/gfx/platform_font_win.cc#...
ui/gfx/platform_font_win.cc:321: HFONT
PlatformFontWin::ConvertGDIFontToDirectWriteFont(HFONT gdi_font) {
seems a bit weird to me that that round trip actually does what want, but if it
works...

https://codereview.chromium.org/692633003/diff/1/ui/gfx/platform_font_win.cc#...
ui/gfx/platform_font_win.cc:331: CHECK(false);
check(false); return NULL; doesn't make any sense, it can't get past the check
(+ 2 more below)

[ananta, 2014-10-29 21:56:18]

https://codereview.chromium.org/692633003/diff/1/content/browser/browser_main...
File content/browser/browser_main_runner.cc (right):

https://codereview.chromium.org/692633003/diff/1/content/browser/browser_main...
content/browser/browser_main_runner.cc:136: return;
On 2014/10/29 21:33:32, scottmg wrote:
> no return

Done.

https://codereview.chromium.org/692633003/diff/1/ui/gfx/platform_font_win.cc
File ui/gfx/platform_font_win.cc (right):

https://codereview.chromium.org/692633003/diff/1/ui/gfx/platform_font_win.cc#...
ui/gfx/platform_font_win.cc:321: HFONT
PlatformFontWin::ConvertGDIFontToDirectWriteFont(HFONT gdi_font) {
On 2014/10/29 21:33:32, scottmg wrote:
> seems a bit weird to me that that round trip actually does what want, but if
it
> works...

Yes. I had a hunch though :)

https://codereview.chromium.org/692633003/diff/1/ui/gfx/platform_font_win.cc#...
ui/gfx/platform_font_win.cc:331: CHECK(false);
On 2014/10/29 21:33:32, scottmg wrote:
> check(false); return NULL; doesn't make any sense, it can't get past the check
> (+ 2 more below)

Added the returns for semantics only.

[sky, 2014-10-29 22:04:32]

LGTM

https://codereview.chromium.org/692633003/diff/20001/content/browser/browser_...
File content/browser/browser_main_runner.cc (right):

https://codereview.chromium.org/692633003/diff/20001/content/browser/browser_...
content/browser/browser_main_runner.cc:135: CHECK(false);
CHECK(dwrite_create_factory_proc)?

[ananta, 2014-10-29 22:25:35]

https://codereview.chromium.org/692633003/diff/20001/content/browser/browser_...
File content/browser/browser_main_runner.cc (right):

https://codereview.chromium.org/692633003/diff/20001/content/browser/browser_...
content/browser/browser_main_runner.cc:135: CHECK(false);
On 2014/10/29 22:04:32, sky wrote:
> CHECK(dwrite_create_factory_proc)?

Done.

[ananta, 2014-10-29 22:44:43]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2014-10-29 22:48:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/692633003/40001

[commit-bot: I haz the power, 2014-10-30 00:14:51]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-10-30 00:15:40]

Patchset 3 (id:??) landed as
https://crrev.com/9fd5754d8c121d7c6fbc5b88d361a1c3e0d03900
Cr-Commit-Position: refs/heads/master@{#301987}