Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Side by Side Diff: chrome/browser/ui/webui/bidi_checker_web_ui_test.cc

Issue 69263003: Remove stale comments (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/bidi_checker_web_ui_test.h" 5 #include "chrome/browser/ui/webui/bidi_checker_web_ui_test.h"
6 6
7 #include "base/base_paths.h" 7 #include "base/base_paths.h"
8 #include "base/i18n/rtl.h" 8 #include "base/i18n/rtl.h"
9 #include "base/message_loop/message_loop.h" 9 #include "base/message_loop/message_loop.h"
10 #include "base/path_service.h" 10 #include "base/path_service.h"
(...skipping 148 matching lines...) Expand 10 before | Expand all | Expand 10 after
159 const std::string& page_url, 159 const std::string& page_url,
160 const std::string& page_title) { 160 const std::string& page_title) {
161 HistoryService* history_service = HistoryServiceFactory::GetForProfile( 161 HistoryService* history_service = HistoryServiceFactory::GetForProfile(
162 browser->profile(), Profile::IMPLICIT_ACCESS); 162 browser->profile(), Profile::IMPLICIT_ACCESS);
163 const GURL history_url = GURL(page_url); 163 const GURL history_url = GURL(page_url);
164 history_service->AddPage( 164 history_service->AddPage(
165 history_url, base::Time::Now(), history::SOURCE_BROWSED); 165 history_url, base::Time::Now(), history::SOURCE_BROWSED);
166 history_service->SetPageTitle(history_url, UTF8ToUTF16(page_title)); 166 history_service->SetPageTitle(history_url, UTF8ToUTF16(page_title));
167 } 167 }
168 168
169 // TODO(estade): fix this test: http://crbug.com/119595
170 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR, 169 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR,
171 TestHistoryPage) { 170 TestHistoryPage) {
172 // Test an Israeli news site with a Hebrew title. 171 // Test an Israeli news site with a Hebrew title.
173 SetupHistoryPageTest(browser(), 172 SetupHistoryPageTest(browser(),
174 "http://www.ynet.co.il", 173 "http://www.ynet.co.il",
175 "\xD7\x91\xD7\x93\xD7\x99\xD7\xA7\xD7\x94\x21"); 174 "\xD7\x91\xD7\x93\xD7\x99\xD7\xA7\xD7\x94\x21");
176 RunBidiCheckerOnPage(chrome::kChromeUIHistoryFrameURL); 175 RunBidiCheckerOnPage(chrome::kChromeUIHistoryFrameURL);
177 } 176 }
178 177
179 // TODO(estade): fix this test: http://crbug.com/119595
180 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL, 178 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL,
181 TestHistoryPage) { 179 TestHistoryPage) {
182 SetupHistoryPageTest(browser(), "http://www.google.com", "Google"); 180 SetupHistoryPageTest(browser(), "http://www.google.com", "Google");
183 RunBidiCheckerOnPage(chrome::kChromeUIHistoryFrameURL); 181 RunBidiCheckerOnPage(chrome::kChromeUIHistoryFrameURL);
184 } 182 }
185 183
186 //============================== 184 //==============================
187 // chrome://about 185 // chrome://about
188 //============================== 186 //==============================
189 187
(...skipping 550 matching lines...) Expand 10 before | Expand all | Expand 10 after
740 // chrome://history-frame 738 // chrome://history-frame
741 //============================== 739 //==============================
742 740
743 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR, TestHistoryFrame) { 741 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestLTR, TestHistoryFrame) {
744 RunBidiCheckerOnPage(chrome::kChromeUIHistoryFrameURL); 742 RunBidiCheckerOnPage(chrome::kChromeUIHistoryFrameURL);
745 } 743 }
746 744
747 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL, TestHistoryFrame) { 745 IN_PROC_BROWSER_TEST_F(WebUIBidiCheckerBrowserTestRTL, TestHistoryFrame) {
748 RunBidiCheckerOnPage(chrome::kChromeUIHistoryFrameURL); 746 RunBidiCheckerOnPage(chrome::kChromeUIHistoryFrameURL);
749 } 747 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698