Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 692623002: Revert of Use remove_build_metadata.py on all the trybots. (Closed)

Created:
6 years, 1 month ago by Sébastien Marchand
Modified:
6 years, 1 month ago
Reviewers:
M-A Ruel
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Project:
tools
Visibility:
Public.

Description

Revert of Use remove_build_metadata.py on all the trybots. (patchset #1 id:40001 of https://codereview.chromium.org/654543008/) Reason for revert: The remove_build_metadata step shouldn't be a failing step for now (it should just give a warning if zap_timestamp.exe fail for some targets), I'll change that an I'll reland this one. Original issue's description: > Use remove_build_metadata.py on all the trybots. > > BUG= > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292727 TBR=maruel@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292730

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -123 lines) Patch
M scripts/slave/recipes/chromium_trybot.py View 1 chunk +2 lines, -6 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/arm.json View 1 chunk +0 lines, -13 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json View 1 chunk +0 lines, -13 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests.json View 1 chunk +0 lines, -13 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests_no_builder.json View 1 chunk +0 lines, -13 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_arm.json View 1 chunk +0 lines, -13 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_basic_cq.json View 1 chunk +0 lines, -13 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_basic_try_job.json View 1 chunk +0 lines, -13 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_deapply_patch.json View 1 chunk +0 lines, -13 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_missing_isolated.json View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sébastien Marchand
Created Revert of Use remove_build_metadata.py on all the trybots.
6 years, 1 month ago (2014-10-29 19:03:24 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692623002/1
6 years, 1 month ago (2014-10-29 19:04:04 UTC) #2
M-A Ruel
On 2014/10/29 19:03:24, Sébastien Marchand wrote: > Created Revert of Use remove_build_metadata.py on all the ...
6 years, 1 month ago (2014-10-29 19:04:33 UTC) #3
M-A Ruel
On 2014/10/29 19:04:33, M-A Ruel wrote: > On 2014/10/29 19:03:24, Sébastien Marchand wrote: > > ...
6 years, 1 month ago (2014-10-29 19:04:41 UTC) #4
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 19:05:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 292730

Powered by Google App Engine
This is Rietveld 408576698