Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 692593003: More robust matrix decomposition (Closed)

Created:
6 years, 1 month ago by Lof
Modified:
6 years, 1 month ago
Reviewers:
Ian Vollick
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

More robust matrix decomposition We decompose matrix, containing scale. So we lose precision and get rotation due to multiplication on 1.0/x instead of divide on x. R=vollick@chromium.org TEST=XFormTest.DecomposeTransform Committed: https://crrev.com/d6e4728f3c0785c3e0e6ce8e5e33f579cee71c7b Cr-Commit-Position: refs/heads/master@{#302084}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -11 lines) Patch
M ui/gfx/transform_unittest.cc View 1 chunk +15 lines, -0 lines 0 comments Download
M ui/gfx/transform_util.cc View 4 chunks +15 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Lof
6 years, 1 month ago (2014-10-29 21:51:08 UTC) #1
Ian Vollick
On 2014/10/29 at 21:51:08, lof84 wrote: > The hope was that multiplying by 1/x would ...
6 years, 1 month ago (2014-10-30 14:12:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692593003/1
6 years, 1 month ago (2014-10-30 14:13:57 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-30 15:07:38 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 15:08:17 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6e4728f3c0785c3e0e6ce8e5e33f579cee71c7b
Cr-Commit-Position: refs/heads/master@{#302084}

Powered by Google App Engine
This is Rietveld 408576698