Issue 692563005: Merge 184123 "Don't delete objects from the floating list during..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 692563005: Merge 184123 "Don't delete objects from the floating list during..." (Closed)

Created:
6 years, 1 month ago by amineer_google

Modified:
6 years, 1 month ago

Reviewers:
rhogan

CC:
blink-reviews, blink-reviews-rendering, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, rune+blink

Base URL:
svn://svn.chromium.org/blink/branches/chromium/2171/

Project:
blink

Visibility:
Public.

More Reviews

Description

Merge 184123 "Don't delete objects from the floating list during..." Merging to branch BUG=423891 > Don't delete objects from the floating list during layout > > In https://codereview.chromium.org/635533003 I was wrong to treat isInPerformLayout > as equivalent to when a shape is being computed. This crash reveals there are cases > where that doesn't hold - so reinstating the check. > > This is a reduced version of the clusterfuzz test - it resisted my attempts to remove > anything further from it. > > BUG=423891 > > Review URL: https://codereview.chromium.org/647953004 TBR=robhogan@gmail.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184801

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	Source/core/rendering/RenderBox.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r184801.

Expand Messages | Collapse Messages