Remove more support for floats from RenderBlockFlow.

Remove more support for floats from RenderBlockFlow.

This doesn't change any behavior. Floats were already removed.
This is just removing effectively noop code.

R=esprehn@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/6520ca7c9d813c1a235a192b6401ca0a84491a0d

[ojan, 2014-11-03 20:23:05]

ojan@chromium.org changed reviewers:
+ esprehn@chromium.org

[esprehn, 2014-11-03 20:25:45]

https://codereview.chromium.org/692563004/diff/1/sky/engine/core/rendering/Re...
File sky/engine/core/rendering/RenderBlockFlow.cpp (right):

https://codereview.chromium.org/692563004/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderBlockFlow.cpp:261: newPosition =
std::max(newPosition, childMarginStart);
I think you merged the wrong side of the branch here?

[ojan, 2014-11-03 20:27:06]

https://codereview.chromium.org/692563004/diff/1/sky/engine/core/rendering/Re...
File sky/engine/core/rendering/RenderBlockFlow.cpp (right):

https://codereview.chromium.org/692563004/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderBlockFlow.cpp:261: newPosition =
std::max(newPosition, childMarginStart);
On 2014/11/03 20:25:45, esprehn wrote:
> I think you merged the wrong side of the branch here?

?

[ojan, 2014-11-03 20:28:10]

https://codereview.chromium.org/692563004/diff/1/sky/engine/core/rendering/Re...
File sky/engine/core/rendering/RenderBlockFlow.cpp (right):

https://codereview.chromium.org/692563004/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderBlockFlow.cpp:261: newPosition =
std::max(newPosition, childMarginStart);
On 2014/11/03 20:27:06, ojan wrote:
> On 2014/11/03 20:25:45, esprehn wrote:
> > I think you merged the wrong side of the branch here?
> 
> ?

positionToAvoidFloats is always 0 since there are no floats.

[ojan, 2014-11-03 20:28:52]

https://codereview.chromium.org/692563004/diff/1/sky/engine/core/rendering/Re...
File sky/engine/core/rendering/RenderBlockFlow.cpp (right):

https://codereview.chromium.org/692563004/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderBlockFlow.cpp:261: newPosition =
std::max(newPosition, childMarginStart);
On 2014/11/03 at 20:28:10, ojan wrote:
> On 2014/11/03 20:27:06, ojan wrote:
> > On 2014/11/03 20:25:45, esprehn wrote:
> > > I think you merged the wrong side of the branch here?
> > 
> > ?
> 
> positionToAvoidFloats is always 0 since there are no floats.

Ah, this is much more clear if you see this in the side-by-side diff.

[esprehn, 2014-11-03 20:30:44]

lgtm

https://codereview.chromium.org/692563004/diff/1/sky/engine/core/rendering/Re...
File sky/engine/core/rendering/RenderBlockFlow.cpp (right):

https://codereview.chromium.org/692563004/diff/1/sky/engine/core/rendering/Re...
sky/engine/core/rendering/RenderBlockFlow.cpp:261: newPosition =
std::max(newPosition, childMarginStart);
On 2014/11/03 at 20:25:45, esprehn wrote:
> I think you merged the wrong side of the branch here?

Oh I see what happened here.

[ojan, 2014-11-03 20:40:14]

Committed patchset #1 (id:1) manually as
6520ca7c9d813c1a235a192b6401ca0a84491a0d (presubmit successful).