Issue 692513003: Use the most recent version of ADB from the SDK if necessary.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 692513003: Use the most recent version of ADB from the SDK if necessary. (Closed)

Created:
6 years, 1 month ago by djsollen

Modified:
6 years, 1 month ago

Reviewers:
hcm, borenet, scroggo, tomhudson

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

Use the most recent version of ADB from the SDK if necessary. This removes ADB from the Skia checkout and also does some quick checks to make sure the version of ADB used meets a minimum threshold Committed: https://skia.googlesource.com/skia/+/f49bba8104a8790a628eabba33c8ee8e5e6e2e5a

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -7 lines)			Patch
	M	platform_tools/android/bin/utils/setup_adb.sh	View		1 chunk	+25 lines, -7 lines	0 comments	Download

Total messages: 6 (2 generated)

djsollen

we need to keep adb around in platform_tools for now until we can get the ...

6 years, 1 month ago (2014-10-29 19:39:32 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692513003/20001

6 years, 1 month ago (2014-10-30 11:40:34 UTC) #5

commit-bot: I haz the power

6 years, 1 month ago (2014-10-30 12:57:34 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as f49bba8104a8790a628eabba33c8ee8e5e6e2e5a