Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(333)

Issue 692503002: Remove obsolete "android_src" gyp/gn variable. (Closed)

Created:
6 years, 1 month ago by Torne
Modified:
6 years, 1 month ago
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove obsolete "android_src" gyp/gn variable. Now that the android webview build uses the NDK there is no longer any need to refer to the root of the android source tree; remove the variable to prevent any new uses being introduced. BUG= Committed: https://crrev.com/dcdc0932a5809b3e8bdebb81051b429bbf9786fc Cr-Commit-Position: refs/heads/master@{#301863}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
M android_webview/tools/gyp_webview View 1 chunk +0 lines, -1 line 0 comments Download
M build/config/android/config.gni View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
Torne
6 years, 1 month ago (2014-10-29 12:42:52 UTC) #2
mkosiba (inactive)
lgtm
6 years, 1 month ago (2014-10-29 15:39:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692503002/1
6 years, 1 month ago (2014-10-29 15:41:45 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/20918)
6 years, 1 month ago (2014-10-29 15:49:14 UTC) #7
Torne
oops, need to wait for cjhopman :)
6 years, 1 month ago (2014-10-29 15:53:02 UTC) #8
cjhopman
lgtm
6 years, 1 month ago (2014-10-29 17:10:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692503002/1
6 years, 1 month ago (2014-10-29 17:21:12 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-10-29 17:26:39 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-10-29 17:27:52 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dcdc0932a5809b3e8bdebb81051b429bbf9786fc
Cr-Commit-Position: refs/heads/master@{#301863}

Powered by Google App Engine
This is Rietveld 408576698