Hook up DidReceiveInputEvent to the blink scheduler

content/renderer/scheduler/renderer_scheduler_impl_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/scheduler/renderer_scheduler_impl.h"
 
 #include "base/callback.h"
 #include "cc/output/begin_frame_args.h"
 #include "cc/test/ordered_simple_task_runner.h"
 #include "testing/gmock/include/gmock/gmock.h"
@@ skipping 221 matching lines @@
   EnableIdleTasks();
   RunUntilIdle();
   EXPECT_THAT(order,
               testing::ElementsAre(std::string("D1"),
                                    std::string("C1"),
                                    std::string("D2"),
                                    std::string("C2"),
                                    std::string("I1")));
 }
 
-TEST_F(RendererSchedulerImplTest, TestCompositorPolicy) {
+TEST_F(RendererSchedulerImplTest, TestCompositorPolicy_DidAnimate) {

[rmcilroy, 2014/11/06 00:53:16]

I don't think we need to add _DidAnimate here.

[alex clarke (OOO till 29th), 2014/11/06 19:21:45]

It kind of is, I didn't intend to delete the original test.

   std::vector<std::string> order;
 
   idle_task_runner_->PostIdleTask(
       FROM_HERE,
       base::Bind(&AppendToVectorIdleTestTask, &order, std::string("I1")));
   default_task_runner_->PostTask(
       FROM_HERE,
       base::Bind(&AppendToVectorTestTask, &order, std::string("D1")));
   compositor_task_runner_->PostTask(
       FROM_HERE,
       base::Bind(&AppendToVectorTestTask, &order, std::string("C1")));
   default_task_runner_->PostTask(
       FROM_HERE,
       base::Bind(&AppendToVectorTestTask, &order, std::string("D2")));
   compositor_task_runner_->PostTask(
       FROM_HERE,
       base::Bind(&AppendToVectorTestTask, &order, std::string("C2")));
 
-  scheduler_->DidReceiveInputEvent();
+  scheduler_->DidAnimate();

[rmcilroy, 2014/11/06 00:53:17]

Please keep the DidReceiveInputEvent() compositor mode trigger testing here, and
also add a separate test for DidAnimate (either in the same test function or a
new one).

[alex clarke (OOO till 29th), 2014/11/06 19:21:45]

Done.

   EnableIdleTasks();
   RunUntilIdle();
   EXPECT_THAT(order,
               testing::ElementsAre(std::string("C1"),
                                    std::string("C2"),
                                    std::string("D1"),
                                    std::string("D2"),
                                    std::string("I1")));
 }
 
@@ skipping 66 matching lines @@
   // Compositor policy mode should have ended now that the clock has advanced.
   RunUntilIdle();
   EXPECT_THAT(order,
               testing::ElementsAre(std::string("D1"),
                                    std::string("C1"),
                                    std::string("D2"),
                                    std::string("C2")));
 }
 
 }  // namespace content