Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 692473003: cc: Translate the canvas to correctly detect solid colors (Closed)

Created:
6 years, 1 month ago by hendrikw
Modified:
6 years, 1 month ago
Reviewers:
vmpstr
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

cc: Translate the canvas to correctly detect solid colors While animating the transition, the origin is off in outerspace, as a result we weren't correctly detecting the layer as non-solid since the bitmap wasn't in the viewport Also wrote a test for this. BUG=420571 Committed: https://crrev.com/232beac2bca96ba31e3a7186742e9c647b422274 Cr-Commit-Position: refs/heads/master@{#301983}

Patch Set 1 #

Patch Set 2 : Added a test #

Total comments: 3

Patch Set 3 : Address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M cc/resources/picture_pile.cc View 1 chunk +2 lines, -1 line 0 comments Download
M cc/resources/picture_pile_unittest.cc View 1 2 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
hendrikw
PTAL, thanks!
6 years, 1 month ago (2014-10-29 18:04:15 UTC) #2
vmpstr
lgtm % test
6 years, 1 month ago (2014-10-29 18:06:48 UTC) #3
hendrikw
PTAL
6 years, 1 month ago (2014-10-29 21:23:10 UTC) #4
vmpstr
https://codereview.chromium.org/692473003/diff/20001/cc/resources/picture_pile_unittest.cc File cc/resources/picture_pile_unittest.cc (right): https://codereview.chromium.org/692473003/diff/20001/cc/resources/picture_pile_unittest.cc#newcode1435 cc/resources/picture_pile_unittest.cc:1435: TEST_F(PicturePileTest, NonSolidRectangleOnOffsetedLayerIsNonSolid) { Offset? https://codereview.chromium.org/692473003/diff/20001/cc/resources/picture_pile_unittest.cc#newcode1438 cc/resources/picture_pile_unittest.cc:1438: gfx::Size tiling_size(tiling_rect.x() + ...
6 years, 1 month ago (2014-10-29 21:41:59 UTC) #5
hendrikw
PTAL again :)
6 years, 1 month ago (2014-10-29 21:58:57 UTC) #6
vmpstr
lgtm
6 years, 1 month ago (2014-10-29 22:20:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692473003/40001
6 years, 1 month ago (2014-10-29 22:26:53 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-10-30 00:02:59 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 00:03:49 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/232beac2bca96ba31e3a7186742e9c647b422274
Cr-Commit-Position: refs/heads/master@{#301983}

Powered by Google App Engine
This is Rietveld 408576698