Issue 692473002: Revert "Various cleanup/simplification in object-observe.js"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 692473002: Revert "Various cleanup/simplification in object-observe.js" (Closed)

Created:
6 years, 1 month ago by adamk

Modified:
6 years, 1 month ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Revert "Various cleanup/simplification in object-observe.js" It broke the context snapshot by trying to get ahold of the per-isolate observation_state object too early. This reverts commit a137cb74fb8f89fabcb0396bebb0bdf248c4b0ae. TBR=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24977

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -38 lines)			Patch
	M	src/object-observe.js	View		8 chunks	+91 lines, -38 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Yang

6 years, 1 month ago (2014-10-29 12:24:50 UTC) #2

Message was sent while issue was closed.

On 2014/10/29 12:15:02, adamk wrote:
> Committed patchset #1 (id:1) manually as 24977.

lgtm.

Expand Messages | Collapse Messages