Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 692433003: Don't require getPropertyCSSValue in fast tests (Closed)

Created:
6 years, 1 month ago by Timothy Loh
Modified:
6 years, 1 month ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Don't require getPropertyCSSValue in fast tests As getPropertyCSSValue is no longer web-exposed we shouldn't require it in tests so we can delete the interface. BUG=428595 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185084

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -78 lines) Patch
M LayoutTests/fast/dom/attribute-namespaces-get-set.html View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/fast/dom/css-element-attribute-js-null.html View 2 chunks +0 lines, -10 lines 0 comments Download
M LayoutTests/fast/dom/css-element-attribute-js-null-expected.txt View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/gc-9.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/gc-9-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/global-constructors.html View 1 chunk +0 lines, -4 lines 0 comments Download
M LayoutTests/fast/dom/non-numeric-values-numeric-parameters-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/prototypes.html View 1 chunk +0 lines, -12 lines 0 comments Download
M LayoutTests/fast/dom/prototypes-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/script-tests/non-numeric-values-numeric-parameters.js View 2 chunks +0 lines, -10 lines 0 comments Download
M LayoutTests/fast/dom/shadow/user-modify-inheritance.html View 2 chunks +10 lines, -17 lines 0 comments Download
M LayoutTests/fast/dom/shadow/user-modify-inheritance-expected.txt View 1 chunk +7 lines, -7 lines 0 comments Download
M LayoutTests/fast/history/visited-generated-content-test.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/media/mq-js-update-media.html View 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/reflections/reflection-computed-style.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/reflections/reflection-computed-style-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Timothy Loh
6 years, 1 month ago (2014-11-10 18:52:11 UTC) #2
alancutter (OOO until 2018)
lgtm
6 years, 1 month ago (2014-11-11 00:18:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692433003/1
6 years, 1 month ago (2014-11-11 00:18:19 UTC) #5
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 01:03:19 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 185084

Powered by Google App Engine
This is Rietveld 408576698